Bug 145739 - Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
Summary: Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-07 14:20 PDT by Brian Burg
Modified: 2015-07-01 10:23 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2015-06-29 16:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2015-06-30 17:06 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Before Patch is applied (24.87 KB, image/png)
2015-06-30 17:08 PDT, Devin Rousso 		no flags Details
After Patch is applied (35.93 KB, image/png)
2015-06-30 17:08 PDT, Devin Rousso 		no flags Details
[Animated GIF] opacity vs hsla (3.42 KB, image/gif)
2015-06-30 22:56 PDT, Nikita Vasilyev 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2015-06-07 14:20:19 PDT 
To match what's done in the console.
Comment 1 Radar WebKit Bug Importer 2015-06-07 14:20:45 PDT 
<rdar://problem/21277790>
Comment 2 Devin Rousso 2015-06-29 16:05:16 PDT 
Created attachment 255789 [details]
Patch
Comment 3 Joseph Pecoraro 2015-06-29 16:33:13 PDT 
Comment on attachment 255789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78
> +.dom-tree-outline li.selected > span::after {
> +    content: " = $0";
> +    opacity: 0.5;
> +}

The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint?
Comment 4 Timothy Hatcher 2015-06-30 09:34:29 PDT 
Comment on attachment 255789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255789&action=review

>> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:78
>> +}
> 
> The $n in the console is: "color: rgba(0, 0, 0, 0.33)". Should we consider the same tint?

I agree.
Comment 5 Brian Burg 2015-06-30 09:53:10 PDT 
Comment on attachment 255789 [details]
Patch

r=me

Please adjust the colors per Joe's comment, and attach before/after screenshots to this bug.
Comment 6 Devin Rousso 2015-06-30 17:06:03 PDT 
Created attachment 255877 [details]
Patch
Comment 7 Devin Rousso 2015-06-30 17:08:03 PDT 
Created attachment 255878 [details]
Before Patch is applied
Comment 8 Devin Rousso 2015-06-30 17:08:18 PDT 
Created attachment 255879 [details]
After Patch is applied
Comment 9 WebKit Commit Bot 2015-06-30 19:08:34 PDT 
Comment on attachment 255877 [details]
Patch

Clearing flags on attachment: 255877

Committed r186163: <http://trac.webkit.org/changeset/186163>
Comment 10 WebKit Commit Bot 2015-06-30 19:08:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Nikita Vasilyev 2015-06-30 22:56:10 PDT 
Created attachment 255901 [details]
[Animated GIF] opacity vs hsla

It's important to use rgba/hsla over opacity, as the latter disables subpixel anti-aliasing. The committed change uses opacity.
Comment 12 Timothy Hatcher 2015-07-01 10:23:09 PDT 
(In reply to comment #11)
> Created attachment 255901 [details]
> [Animated GIF] opacity vs hsla
> 
> It's important to use rgba/hsla over opacity, as the latter disables
> subpixel anti-aliasing. The committed change uses opacity.

Good point. Lets fix that. rs=me