Bug 145735 - REGRESSION(r185262): [GTK] webkit_web_context_set_disk_cache_directory() doesn't work after r185262
Summary: REGRESSION(r185262): [GTK] webkit_web_context_set_disk_cache_directory() does...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression, Soup
Depends on:
Blocks:
 
Reported: 2015-06-07 03:45 PDT by Carlos Garcia Campos
Modified: 2015-06-07 23:36 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.22 KB, patch)
2015-06-07 03:51 PDT, Carlos Garcia Campos
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-06-07 03:45:49 PDT
We need  way to change the web process pool configuration, and also move to the UI process the disk cache subdirectory handling. This is an API break, because webkit_web_context_set_disk_cache_directory() does nothing now.
Comment 1 Carlos Garcia Campos 2015-06-07 03:51:44 PDT
Created attachment 254435 [details]
Patch

The shared secondary process model is still broken, but because of r185251.
Comment 2 WebKit Commit Bot 2015-06-07 03:52:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2015-06-07 23:36:08 PDT
Committed r185311: <http://trac.webkit.org/changeset/185311>