Bug 145719 – [iOS] Don't force compositing layers for no-op 3D transforms on low-memory devices.

• Status: REOPENED
• Component: Layout and Rendering

[Andreas Kling]

<rdar://problem/19973042>

[Andreas Kling]

Created attachment 254398 [details]
Patch

[WebKit Commit Bot]

Attachment 254398 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerCompositor.cpp:66:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 254398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254398&action=review

r=me

> Source/WebCore/rendering/RenderLayerCompositor.cpp:2476
> +    static uint64_t memSize = ramSize() / 1024 / 1024;

Please call this ramSizeInMB.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:2478
> +        // Special policy for low-memory devices: Don't require compositing just because there's a no-op 3D transform.

I really really really wish we did this all the time.

[Andreas Kling]

(In reply to comment #3) 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:2478
> > +        // Special policy for low-memory devices: Don't require compositing just because there's a no-op 3D transform.
> 
> I really really really wish we did this all the time.

Me too, really x3.

[Andreas Kling]

Committed r185284: <http://trac.webkit.org/changeset/185284>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 145723

[Darin Adler]

Comment on attachment 254398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254398&action=review

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:2476
>> +    static uint64_t memSize = ramSize() / 1024 / 1024;
> 
> Please call this ramSizeInMB.

If we are going to precompute and cache something, I suggest caching the boolean that indicates whether we should do the special policy. Not as good to instead cache a 64-bit number and keep comparing it against 512 over and over again.