Bug 145703 – MediaSessions should keep track of their participating media elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

Per the Media Session spec, media sessions should keep track of their participating media elements. We will also need a convenience accessor to the active participating media elements when activating media sessions, handling MediaPlayPause events, and more.

[Radar WebKit Bug Importer]

<rdar://problem/21263059>

[Matt Rajca]

Created attachment 254373 [details]
Patch

[Eric Carlson]

Comment on attachment 254373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254373&action=review

> Source/WebCore/Modules/mediasession/MediaSession.h:63
>      State m_currentState { State::Idle };
>  
> +    friend class HTMLMediaElement;
> +
> +    Vector<HTMLMediaElement*> m_participatingElements;

Nit: instance variables are typically declared after methods.

[Matt Rajca]

Created attachment 254377 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254377 [details]
Patch

Rejecting attachment 254377 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 254377, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 185261 = 0677956ac2bcc8a1d65a4547f0dfb591c996cefc
r185262 = f91c4b4882085ddc04885a962e70876f59d818ea
r185263 = 065724ea223aa04fb93118eff1d87f7a290df893
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5199210643193856

[Matt Rajca]

Created attachment 254388 [details]
Patch (re-based)

[WebKit Commit Bot]

Comment on attachment 254388 [details]
Patch (re-based)

Clearing flags on attachment: 254388

Committed r185270: <http://trac.webkit.org/changeset/185270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.