Bug 145703 - MediaSessions should keep track of their participating media elements
Summary: MediaSessions should keep track of their participating media elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-06-05 11:37 PDT by Matt Rajca
Modified: 2015-06-05 15:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.46 KB, patch)
2015-06-05 12:55 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (4.48 KB, patch)
2015-06-05 13:41 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (re-based) (4.50 KB, patch)
2015-06-05 14:44 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-06-05 11:37:48 PDT 
Per the Media Session spec, media sessions should keep track of their participating media elements. We will also need a convenience accessor to the active participating media elements when activating media sessions, handling MediaPlayPause events, and more.
Comment 1 Radar WebKit Bug Importer 2015-06-05 11:39:10 PDT 
<rdar://problem/21263059>
Comment 2 Matt Rajca 2015-06-05 12:55:00 PDT 
Created attachment 254373 [details]
Patch
Comment 3 Eric Carlson 2015-06-05 13:38:39 PDT 
Comment on attachment 254373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254373&action=review

> Source/WebCore/Modules/mediasession/MediaSession.h:63
>      State m_currentState { State::Idle };
>  
> +    friend class HTMLMediaElement;
> +
> +    Vector<HTMLMediaElement*> m_participatingElements;

Nit: instance variables are typically declared after methods.
Comment 4 Matt Rajca 2015-06-05 13:41:14 PDT 
Created attachment 254377 [details]
Patch
Comment 5 WebKit Commit Bot 2015-06-05 14:38:17 PDT 
Comment on attachment 254377 [details]
Patch

Rejecting attachment 254377 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 254377, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 185261 = 0677956ac2bcc8a1d65a4547f0dfb591c996cefc
r185262 = f91c4b4882085ddc04885a962e70876f59d818ea
r185263 = 065724ea223aa04fb93118eff1d87f7a290df893
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5199210643193856
Comment 6 Matt Rajca 2015-06-05 14:44:26 PDT 
Created attachment 254388 [details]
Patch (re-based)
Comment 7 WebKit Commit Bot 2015-06-05 15:33:51 PDT 
Comment on attachment 254388 [details]
Patch (re-based)

Clearing flags on attachment: 254388

Committed r185270: <http://trac.webkit.org/changeset/185270>
Comment 8 WebKit Commit Bot 2015-06-05 15:33:55 PDT 
All reviewed patches have been landed.  Closing bug.