WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145700
Disable the CFNetwork cache in the web process
https://bugs.webkit.org/show_bug.cgi?id=145700
Summary
Disable the CFNetwork cache in the web process
Anders Carlsson
Reported
2015-06-05 10:12:38 PDT
Disable the CFNetwork cache in the web process
Attachments
Patch
(14.33 KB, patch)
2015-06-05 10:13 PDT
,
Anders Carlsson
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2015-06-05 10:13:10 PDT
Created
attachment 254359
[details]
Patch
Geoffrey Garen
Comment 2
2015-06-05 10:14:49 PDT
Comment on
attachment 254359
[details]
Patch r=me
Antti Koivisto
Comment 3
2015-06-05 10:15:55 PDT
Comment on
attachment 254359
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=254359&action=review
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:83 > + printf("cache path is %s\n", networkCachePath.utf8().data());
:|
Anders Carlsson
Comment 4
2015-06-05 10:20:08 PDT
Committed
r185251
: <
http://trac.webkit.org/changeset/185251
>
Carlos Alberto Lopez Perez
Comment 5
2015-06-05 10:48:46 PDT
(In reply to
comment #4
)
> Committed
r185251
: <
http://trac.webkit.org/changeset/185251
>
This broke the GTK build. ../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:142:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters' WebCore::SoupNetworkSession::defaultSession().clearCache(parameters.diskCacheDirectory); ~~~~~~~~~~ ^ ../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:144:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters' String diskCachePath = WebCore::pathByAppendingComponent(parameters.diskCacheDirectory, "webkit"); ~~~~~~~~~~ ^
Carlos Garcia Campos
Comment 6
2015-06-07 03:54:35 PDT
This not only disabled the CFNetwork cache, but also the soup cache, because it removed the disk cache directory from the web process creation parameters. We can bring it back as soup only parameters, though. We will eventually disable it too, but I don't think we are ready.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug