Bug 145700 - Disable the CFNetwork cache in the web process
Summary: Disable the CFNetwork cache in the web process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-05 10:12 PDT by Anders Carlsson
Modified: 2015-06-09 03:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.33 KB, patch)
2015-06-05 10:13 PDT, Anders Carlsson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-06-05 10:12:38 PDT 
Disable the CFNetwork cache in the web process
Comment 1 Anders Carlsson 2015-06-05 10:13:10 PDT 
Created attachment 254359 [details]
Patch
Comment 2 Geoffrey Garen 2015-06-05 10:14:49 PDT 
Comment on attachment 254359 [details]
Patch

r=me
Comment 3 Antti Koivisto 2015-06-05 10:15:55 PDT 
Comment on attachment 254359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254359&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:83
> +    printf("cache path is %s\n", networkCachePath.utf8().data());

:|
Comment 4 Anders Carlsson 2015-06-05 10:20:08 PDT 
Committed r185251: <http://trac.webkit.org/changeset/185251>
Comment 5 Carlos Alberto Lopez Perez 2015-06-05 10:48:46 PDT 
(In reply to comment #4)
> Committed r185251: <http://trac.webkit.org/changeset/185251>

This broke the GTK build.

../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:142:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters'
    WebCore::SoupNetworkSession::defaultSession().clearCache(parameters.diskCacheDirectory);
                                                             ~~~~~~~~~~ ^
../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:144:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters'
    String diskCachePath = WebCore::pathByAppendingComponent(parameters.diskCacheDirectory, "webkit");
                                                             ~~~~~~~~~~ ^
Comment 6 Carlos Garcia Campos 2015-06-07 03:54:35 PDT 
This not only disabled the CFNetwork cache, but also the soup cache, because it removed the disk cache directory from the web process creation parameters. We can bring it back as soup only parameters, though. We will eventually disable it too, but I don't think we are ready.