Bug 145700 – Disable the CFNetwork cache in the web process

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Disable the CFNetwork cache in the web process

[Anders Carlsson]

Created attachment 254359 [details]
Patch

[Geoffrey Garen]

Comment on attachment 254359 [details]
Patch

r=me

[Antti Koivisto]

Comment on attachment 254359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254359&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:83
> +    printf("cache path is %s\n", networkCachePath.utf8().data());

:|

[Anders Carlsson]

Committed r185251: <http://trac.webkit.org/changeset/185251>

[Carlos Alberto Lopez Perez]

(In reply to comment #4)
> Committed r185251: <http://trac.webkit.org/changeset/185251>

This broke the GTK build.

../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:142:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters'
    WebCore::SoupNetworkSession::defaultSession().clearCache(parameters.diskCacheDirectory);
                                                             ~~~~~~~~~~ ^
../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:144:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters'
    String diskCachePath = WebCore::pathByAppendingComponent(parameters.diskCacheDirectory, "webkit");
                                                             ~~~~~~~~~~ ^

[Carlos Garcia Campos]

This not only disabled the CFNetwork cache, but also the soup cache, because it removed the disk cache directory from the web process creation parameters. We can bring it back as soup only parameters, though. We will eventually disable it too, but I don't think we are ready.