Bug 145695 – REGRESSION (r185213): TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value')

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Mark Lam]

This error started showing up after r185213: <http://trac.webkit.org/changeset/185213>.  The complete error message says:

Uncaught exception in inspector page: TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value') [file:///.../OpenSource/WebKitBuild/Debug/WebInspectorUI.framework/Resources/Controllers/LogManager.js:77]

I see that WebInspector.clearLogOnReload is initialized by WebInspector.loaded() in Main.js.  Are we guaranteed that WebInspector.loaded will be called before the first use of WebInspector.clearLogOnReload?  I'm seeing the above error while trying to run new inspector tests I'm writing to test exception breakpoints.

[Radar WebKit Bug Importer]

<rdar://problem/21260137>

[Mark Lam]

To reproduce this issue:

1. Comment out the asserts in InspectorTimelineAgent.cpp if the fix for https://bugs.webkit.org/show_bug.cgi?id=145090 is not yet landed.

2. Run the following inspector tests (landed in r185259):

OpenSource$ ./Tools/Scripts/run-webkit-tests -1 --debug inspector/debugger/break-on-*

That should run a set of 20 tests.  The issue will manifest intermittently on a subset of those tests, and result in failures due to text diffs.

[Joseph Pecoraro]

(In reply to comment #0)
> This error started showing up after r185213:
> <http://trac.webkit.org/changeset/185213>.  The complete error message says:
> 
> Uncaught exception in inspector page: TypeError: undefined is not an object
> (evaluating 'WebInspector.clearLogOnReload.value')
> [file:///.../OpenSource/WebKitBuild/Debug/WebInspectorUI.framework/Resources/
> Controllers/LogManager.js:77]

It sounds like you reproduced this running tests. I suspect this is a Tests only issue. We just need to add a fake WebInspector.clearLogOnReload WebInspector.Setting to Test.js. Or, move it to LogManager like I suggested.

I'll take a quick look.

[Joseph Pecoraro]

Created attachment 254389 [details]
[PATCH] Proposed Fix

[Mark Lam]

Comment on attachment 254389 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 254389 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 254389

Committed r185271: <http://trac.webkit.org/changeset/185271>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.