Bug 145694 - 3% cold PLT regression from network cache on iOS
Summary: 3% cold PLT regression from network cache on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-05 08:32 PDT by Antti Koivisto
Modified: 2015-06-16 12:06 PDT (History)
6 users (show)

See Also:

Attachments
patch (5.79 KB, patch)
2015-06-05 10:24 PDT, Antti Koivisto 		cdumez: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (578.34 KB, application/zip)
2015-06-05 11:03 PDT, Build Bot 		no flags Details
patch (7.66 KB, patch)
2015-06-06 03:59 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-06-05 08:32:41 PDT 
Cache does not help in cold PLT but it shouldn't be hurting either. Write I/O during page load needs to be toned down a bit.
Comment 1 Antti Koivisto 2015-06-05 08:33:17 PDT 
rdar://problem/21158245
Comment 2 Antti Koivisto 2015-06-05 10:24:32 PDT 
Created attachment 254362 [details]
patch
Comment 3 Chris Dumez 2015-06-05 10:34:34 PDT 
Comment on attachment 254362 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254362&action=review

r=me

> Source/WebKit2/ChangeLog:5
> +

No radar tracking this?
Comment 4 Build Bot 2015-06-05 11:02:51 PDT 
Comment on attachment 254362 [details]
patch

Attachment 254362 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4560341237235712

New failing tests:
http/tests/cache/disk-cache/disk-cache-vary-cookie.html
Comment 5 Build Bot 2015-06-05 11:03:04 PDT 
Created attachment 254364 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Antti Koivisto 2015-06-06 03:59:40 PDT 
Created attachment 254412 [details]
patch
Comment 7 Antti Koivisto 2015-06-11 05:06:58 PDT 
http://trac.webkit.org/changeset/185452
Comment 8 Chris Dumez 2015-06-16 12:06:47 PDT 
This change seems to have caused a ~4% regression on Membuster.