Bug 145682 - [CMake] Error when gst-plugins-base is missing is too confusing
Summary: [CMake] Error when gst-plugins-base is missing is too confusing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
: 145887 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-04 20:26 PDT by Michael Catanzaro
Modified: 2015-06-30 00:19 PDT (History)
5 users (show)

See Also:

Attachments
patch (2.70 KB, patch)
2015-06-18 08:29 PDT, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-06-04 20:26:08 PDT 
If gstreamer is installed but gst-plugins-base is not, we get a horrible build error. We should do better than this.

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
GSTREAMER_APP_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_AUDIO_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_FFT_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_PBUTILS_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_TAG_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_VIDEO_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore

-- Configuring incomplete, errors occurred!
See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeOutput.log".
See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeError.log".
Comment 1 Michael Catanzaro 2015-06-11 12:37:08 PDT 
*** Bug 145887 has been marked as a duplicate of this bug. ***
Comment 2 Philippe Normand 2015-06-18 07:26:37 PDT 
CMake should error out early if, for instance, the gstreamer-video-1.0 pkgconfig file isn't found.
Comment 3 Philippe Normand 2015-06-18 07:39:38 PDT 
I'm starting to work on a small (I hope) patch for this.
Comment 4 Philippe Normand 2015-06-18 08:29:10 PDT 
Created attachment 255116 [details]
patch
Comment 5 Michael Catanzaro 2015-06-18 09:20:36 PDT 
Patch LGTM.
Comment 6 Philippe Normand 2015-06-29 00:52:33 PDT 
Hi Carlos, can you please have a look at this patch?
Comment 7 Philippe Normand 2015-06-30 00:19:08 PDT 
Committed r186110: <http://trac.webkit.org/changeset/186110>