RESOLVED FIXED 145682
[CMake] Error when gst-plugins-base is missing is too confusing 
https://bugs.webkit.org/show_bug.cgi?id=145682
Summary [CMake] Error when gst-plugins-base is missing is too confusing
Michael Catanzaro
Reported 2015-06-04 20:26:08 PDT
If gstreamer is installed but gst-plugins-base is not, we get a horrible build error. We should do better than this. CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: GSTREAMER_APP_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_AUDIO_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_FFT_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_PBUTILS_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_TAG_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore GSTREAMER_VIDEO_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore -- Configuring incomplete, errors occurred! See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeOutput.log". See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeError.log".
Attachments
patch (2.70 KB, patch)
2015-06-18 08:29 PDT, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-06-11 12:37:08 PDT
*** Bug 145887 has been marked as a duplicate of this bug. ***
Philippe Normand
Comment 2 2015-06-18 07:26:37 PDT
CMake should error out early if, for instance, the gstreamer-video-1.0 pkgconfig file isn't found.
Philippe Normand
Comment 3 2015-06-18 07:39:38 PDT
I'm starting to work on a small (I hope) patch for this.
Philippe Normand
Comment 4 2015-06-18 08:29:10 PDT
Created attachment 255116 [details] patch
Michael Catanzaro
Comment 5 2015-06-18 09:20:36 PDT
Patch LGTM.
Philippe Normand
Comment 6 2015-06-29 00:52:33 PDT
Hi Carlos, can you please have a look at this patch?
Philippe Normand
Comment 7 2015-06-30 00:19:08 PDT
Committed r186110: <http://trac.webkit.org/changeset/186110>
Note You need to log in before you can comment on or make changes to this bug.