Bug 145668 – Web Inspector: Fixing code style and adding more limitations for bug 141262

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Fixing style changes in https://bugs.webkit.org/show_bug.cgi?id=141262.  In addition, code was added to prevent the invalid strikethrough from being applied to the following cases:
 - <property name>:   // Only the property name and colon are present.
 - <property name>:     <property value>; // Multiple/zero spaces are present between the colon and property value (caused the strikethrough to be applied to the wrong selection of text).

[Radar WebKit Bug Importer]

<rdar://problem/21250324>

[Devin Rousso]

Created attachment 254309 [details]
Patch

[Timothy Hatcher]

Comment on attachment 254309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254309&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:538
> +        if (!property.valid && propertyNameIsValid && property.text.slice(-1) !== ":") {

.trim().endsWith(":")?

[Devin Rousso]

Created attachment 254392 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254392 [details]
Patch

Rejecting attachment 254392 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 254392, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6439325541597184

[Timothy Hatcher]

Comment on attachment 254392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254392&action=review

> Source/WebInspectorUI/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Double ChangeLog.

[Devin Rousso]

Created attachment 254402 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254402 [details]
Patch

Clearing flags on attachment: 254402

Committed r185282: <http://trac.webkit.org/changeset/185282>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.