Bug 145668 - Web Inspector: Fixing code style and adding more limitations for bug 141262
Summary: Web Inspector: Fixing code style and adding more limitations for bug 141262
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-06-04 15:44 PDT by Devin Rousso
Modified: 2015-06-05 18:23 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.45 KB, patch)
2015-06-04 15:49 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (4.50 KB, patch)
2015-06-05 15:23 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (4.09 KB, patch)
2015-06-05 17:49 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-06-04 15:44:15 PDT
Fixing style changes in https://bugs.webkit.org/show_bug.cgi?id=141262.  In addition, code was added to prevent the invalid strikethrough from being applied to the following cases:
 - <property name>:   // Only the property name and colon are present.
 - <property name>:     <property value>; // Multiple/zero spaces are present between the colon and property value (caused the strikethrough to be applied to the wrong selection of text).
Comment 1 Radar WebKit Bug Importer 2015-06-04 15:44:40 PDT
<rdar://problem/21250324>
Comment 2 Devin Rousso 2015-06-04 15:49:00 PDT
Created attachment 254309 [details]
Patch
Comment 3 Timothy Hatcher 2015-06-04 21:29:37 PDT
Comment on attachment 254309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254309&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:538
> +        if (!property.valid && propertyNameIsValid && property.text.slice(-1) !== ":") {

.trim().endsWith(":")?
Comment 4 Devin Rousso 2015-06-05 15:23:06 PDT
Created attachment 254392 [details]
Patch
Comment 5 WebKit Commit Bot 2015-06-05 17:28:20 PDT
Comment on attachment 254392 [details]
Patch

Rejecting attachment 254392 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 254392, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6439325541597184
Comment 6 Timothy Hatcher 2015-06-05 17:29:28 PDT
Comment on attachment 254392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254392&action=review

> Source/WebInspectorUI/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Double ChangeLog.
Comment 7 Devin Rousso 2015-06-05 17:49:49 PDT
Created attachment 254402 [details]
Patch
Comment 8 WebKit Commit Bot 2015-06-05 18:23:40 PDT
Comment on attachment 254402 [details]
Patch

Clearing flags on attachment: 254402

Committed r185282: <http://trac.webkit.org/changeset/185282>
Comment 9 WebKit Commit Bot 2015-06-05 18:23:43 PDT
All reviewed patches have been landed.  Closing bug.