Bug 145663 – [Content Extensions] Make max rule count

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

This introduces a max rule count, and it makes the limits on rules and NFA size NSUserDefaults, with default fallback values.

[Alex Christensen]

Created attachment 254304 [details]
Patch

[Benjamin Poulain]

Comment on attachment 254304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254304&action=review

> Source/WebCore/contentextensions/cocoa/ContentExtensionDefaultsCocoa.mm:37
> +    NSInteger maxNFASize = [[NSUserDefaults standardUserDefaults] integerForKey:@"ContentExtensionMaxNFASize"];

Shouldn't you use WebKit preferences that are populated by UserDefaults?

Having NSUserDefaults in here is weird

[Alex Christensen]

(In reply to comment #2)
> Shouldn't you use WebKit preferences that are populated by UserDefaults?
Could you point me to code that does something similar?  Would we be able to change/manage that like we want to?

[Alex Christensen]

rdar://problem/21242407

[Alex Christensen]

Created attachment 254694 [details]
Patch

[Benjamin Poulain]

Comment on attachment 254694 [details]
Patch

Can you report the number with the error message?
Can you tweak the number based on the device?
Can you also limit the number of machines we generate?

[Alex Christensen]

http://trac.webkit.org/changeset/185442

I forgot to change the tools change log.  This just added the max rule count.

[Alex Christensen]

(In reply to comment #6)
> Comment on attachment 254694 [details]
> Patch
> 
> Can you report the number with the error message?
> Can you tweak the number based on the device?
> Can you also limit the number of machines we generate?
These could be added later.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 145871

[Alex Christensen]

This caused lots of strange errors in WTF.StringOperators tests.  I'm not sure why, but I'm reverting for now.
https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20%28Tests%29/builds/5975/steps/run-api-tests/logs/stdio

[Alex Christensen]

Comment on attachment 254694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254694&action=review

> Tools/ChangeLog:3
> +        [Content Extensions] Make max NFA size and max rule count user defaults.

And I need to update this ChangeLog entry.

[Alex Christensen]

Created attachment 254878 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254878 [details]
Patch

Clearing flags on attachment: 254878

Committed r185555: <http://trac.webkit.org/changeset/185555>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.