Bug 145650 – [Web Timing] Use new SPI to enable data collection.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

There is a new SPI.  Let's use it.

[Alex Christensen]

Created attachment 254284 [details]
Patch

[Alex Christensen]

This patch does not actually enable data collection.  Someone who knows the SPI should point out what I'm doing wrong.  Maybe it's a strange ObjC problem.  Maybe I'm using the SPI wrong.

[Simon Fraser (smfr)]

Comment on attachment 254284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254284&action=review

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:74
> +// FIXME: Move this to CFNetworkSPI.h.

Seems like this would be a good time to do that.

[Alex Christensen]

Created attachment 254308 [details]
Patch

[Alex Christensen]

Created attachment 254316 [details]
Patch

[Alex Christensen]

(In reply to comment #3)
> Seems like this would be a good time to do that.
I disagree. This is already cross-platform and platform dependent enough. I don't want to mess with breaking Windows in this patch.

[Alex Christensen]

Created attachment 254321 [details]
Patch

[Chris Dumez]

Comment on attachment 254321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254321&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:65
> +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000

Shouldn't this be in Platform.h ?

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:215
> +#if HAVE_TIMINGDATAOPTIONS

#if HAVE(TIMINGDATAOPTIONS)

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:68
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100) || (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000)

Shouldn't this be in Platform.h?

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:79
> +#if !HAVE_TIMINGDATAOPTIONS

#if !HAVE(TIMINGDATAOPTIONS)

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:84
> +#if HAVE_TIMINGDATAOPTIONS

#if HAVE(TIMINGDATAOPTIONS)

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:236
> +#if HAVE_TIMINGDATAOPTIONS

#if HAVE(TIMINGDATAOPTIONS)

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:765
> +#if !HAVE_TIMINGDATAOPTIONS

#if !HAVE(TIMINGDATAOPTIONS)

[Alex Christensen]

Comment on attachment 254321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254321&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:218
> +    CFDictionaryAddValue(propertiesDictionary.get(), CFSTR("kCFURLConnectionURLConnectionProperties"), &TimingDataOptionsEnableW3CNavigationTiming);

timingDataOptionsDictionary here, not propertiesDictionary.

[Alex Christensen]

Comment on attachment 254321 [details]
Patch

And I need to call CFNumberCreate on iOS.

[Alex Christensen]

Created attachment 254381 [details]
Patch

[Chris Dumez]

Comment on attachment 254381 [details]
Patch

r=me

[Alex Christensen]

http://trac.webkit.org/changeset/185264

[Brent Fulgham]

<rdar://problem/21203358>