Bug 145634 - [Cocoa] Clean up m_font inside FontPlatformData
Summary: [Cocoa] Clean up m_font inside FontPlatformData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-03 22:57 PDT by Myles C. Maxfield
Modified: 2015-06-04 09:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (13.64 KB, patch)
2015-06-03 23:13 PDT, Myles C. Maxfield 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-06-03 22:57:05 PDT 
[Cocoa] Clean up m_font inside FontPlatformData
Comment 1 Myles C. Maxfield 2015-06-03 23:13:39 PDT 
Created attachment 254248 [details]
Patch
Comment 2 Myles C. Maxfield 2015-06-03 23:20:46 PDT 
Comment on attachment 254248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254248&action=review

> Source/WebCore/platform/graphics/FontPlatformData.h:215
> +    bool m_isHashTableDeletedValue { false };

If I move this bool down to the rest of them, we get it for free!
Comment 3 Andreas Kling 2015-06-04 08:51:30 PDT 
Comment on attachment 254248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254248&action=review

Oh wow, this is so much nicer. r=me

>> Source/WebCore/platform/graphics/FontPlatformData.h:215
>> +    bool m_isHashTableDeletedValue { false };
> 
> If I move this bool down to the rest of them, we get it for free!

So let's do that too :)
Comment 4 Myles C. Maxfield 2015-06-04 09:51:04 PDT 
Committed r185200: <http://trac.webkit.org/changeset/185200>