RESOLVED FIXED 145634
[Cocoa] Clean up m_font inside FontPlatformData 
https://bugs.webkit.org/show_bug.cgi?id=145634
Summary [Cocoa] Clean up m_font inside FontPlatformData
Myles C. Maxfield
Reported 2015-06-03 22:57:05 PDT
[Cocoa] Clean up m_font inside FontPlatformData
Attachments
Patch (13.64 KB, patch)
2015-06-03 23:13 PDT, Myles C. Maxfield 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-06-03 23:13:39 PDT
Created attachment 254248 [details] Patch
Myles C. Maxfield
Comment 2 2015-06-03 23:20:46 PDT
Comment on attachment 254248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254248&action=review > Source/WebCore/platform/graphics/FontPlatformData.h:215 > + bool m_isHashTableDeletedValue { false }; If I move this bool down to the rest of them, we get it for free!
Andreas Kling
Comment 3 2015-06-04 08:51:30 PDT
Comment on attachment 254248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254248&action=review Oh wow, this is so much nicer. r=me >> Source/WebCore/platform/graphics/FontPlatformData.h:215 >> + bool m_isHashTableDeletedValue { false }; > > If I move this bool down to the rest of them, we get it for free! So let's do that too :)
Myles C. Maxfield
Comment 4 2015-06-04 09:51:04 PDT
Committed r185200: <http://trac.webkit.org/changeset/185200>
Note You need to log in before you can comment on or make changes to this bug.