Bug 145626 - Non-deterministic Inspector Pause and Resume events makes tests flaky
Summary: Non-deterministic Inspector Pause and Resume events makes tests flaky
Status: RESOLVED DUPLICATE of bug 161951
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-03 18:12 PDT by Mark Lam
Modified: 2016-12-14 13:19 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-06-03 18:12:38 PDT 
DebuggerManager.debuggerDidResume() defers the dispatch of the Resumed event.  DebuggerManager.debuggerDidPause() can eat that Resumed event as well as the next Paused Event if debuggerDidPause() happens to be called before debuggerDidResume()'s delayedWork() fires.  As a result, we can cannot write tests that can depend on a consistent order of Pause and Resume events.

I was advised to use the CallFramesDidChange event instead.  The problem with this is that the number of CallFramesDidChange events firing also depends on the race between debuggerDidPause() and debuggerDidResume()'s delayedWork().  For example, the regression test of https://bugs.webkit.org/show_bug.cgi?id=145525 (which is currently written to assume that some Paused and Resume events will be eaten) runs fine on WK1 using DumpRenderTree.  When we run it on WK2 using WKRT which runs a lot slower, the events don't get eaten.  As a result, the test fails.
Comment 1 Radar WebKit Bug Importer 2015-06-03 18:13:12 PDT 
<rdar://problem/21234384>
Comment 2 BJ Burg 2016-12-14 13:19:58 PST 

*** This bug has been marked as a duplicate of bug 161951 ***