RESOLVED WORKSFORME145624
sourceCodeLocation assert in WebInspector.CallFrame.constructor is wrong 
https://bugs.webkit.org/show_bug.cgi?id=145624
Summary sourceCodeLocation assert in WebInspector.CallFrame.constructor is wrong
Mark Lam
Reported 2015-06-03 17:57:35 PDT
Currently, the assertion in WebInspector.CallFrame.constructor expects the sourceCodeLocation to be falsy or be an instance of WebInspector.SourceCodeLocation. Turns out it can also be an instance of WebInspector.LazySourceCodeLocation. The assertion is in error.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-03 17:58:07 PDT
<rdar://problem/21234075>
Nikita Vasilyev
Comment 2 2015-06-04 10:28:11 PDT
class LazySourceCodeLocation extends WebInspector.SourceCodeLocation So, it should be fine. When does the assertion fail?
Mark Lam
Comment 3 2015-06-04 10:30:42 PDT
(In reply to comment #2) > class LazySourceCodeLocation extends WebInspector.SourceCodeLocation > > So, it should be fine. > > When does the assertion fail? I reproduced it by running LayoutTests/inspector/debugger/break-on-exceptions.html which is being introduced in bug 145525.
Nikita Vasilyev
Comment 4 2015-06-26 19:10:30 PDT
I tried running tests on r185858 and they all passed. Please let me know if I'm doing something wrong, I don't know much about the tests. ⮀ Tools/Scripts/run-webkit-tests LayoutTests/inspector/debugger/ Using port 'mac-elcapitan-wk2' Test configuration: <elcapitan, x86_64, release> Placing test results in /Users/nv/Code/Apple/OpenSource/WebKitBuild/Release/layout-test-results Baseline search path: mac-wk2 -> wk2 -> mac -> generic Using Release build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Users/nv/Code/Apple/OpenSource/WebKitBuild/Release/WebKitTestRunner - Found 28 tests; running 28, skipping 0. Running 1 WebKitTestRunner. All 28 tests ran as expected.
Note You need to log in before you can comment on or make changes to this bug.