Bug 145612 - Caps lock indicator should not be shown in read-only or disabled field
Summary: Caps lock indicator should not be shown in read-only or disabled field
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-03 13:08 PDT by Daniel Bates
Modified: 2015-06-03 15:36 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2015-06-03 13:21 PDT, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-06-03 13:08:12 PDT 
We should not show the caps lock indicator in a read-only or disabled field.
Comment 1 Daniel Bates 2015-06-03 13:21:54 PDT 
Created attachment 254202 [details]
Patch

We need to abstract the caps lock logic so as to support automated testing. Currently we check the actual hardware keyboard state for the caps lock key to determine whether to draw the caps lock indicator. Filed bug #145613 to add support for testing the caps lock indicator in DRT/WTR.
Comment 2 Radar WebKit Bug Importer 2015-06-03 13:24:54 PDT 
<rdar://problem/21227454>
Comment 3 Daniel Bates 2015-06-03 15:36:11 PDT 
Committed r185173: <http://trac.webkit.org/changeset/185173>