Bug 145604 – [CSS Grid Layout] Setting height on a grid item doesn't have any effect

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Javier Fernandez]

Created attachment 254173 [details]
Example to reproduce the issue.

If you render a grid and then you modify the height of a grid item (which previously had "height: auto;" and was stretched), the item is not resized as expected.
If align-items is "start" you cannot reproduce the issue.

Attached example to reproduce the issue, when you click on the button the "A" item should be resized to 100x100. Only width is resized.

[Javier Fernandez]

Created attachment 254181 [details]
Example to reproduce the issue.

[Javier Fernandez]

Created attachment 254483 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 254483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254483&action=review

Nice catch!

> Source/WebCore/rendering/RenderGrid.cpp:1300
> +        child.clearOverrideLogicalContentHeight();

Don't we need to mark the child as needs layout in these cases?

[Javier Fernandez]

(In reply to comment #3)
> Comment on attachment 254483 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254483&action=review
> 
> Nice catch!
> 
> > Source/WebCore/rendering/RenderGrid.cpp:1300
> > +        child.clearOverrideLogicalContentHeight();
> 
> Don't we need to mark the child as needs layout in these cases?

No, we don't. The overrideHeight is something we use to indicate, during layout, that instead of computing block's logical height a specific value must be used instead. Since grid layout uses this to set the stretched height, we need to clear it whenever stretching becomes not allowed. Whether block's logical height or not depends on many factors, what changed (width, margin, parent's height, ...) and that is not grid's layout responsibility; a block layout is forced only when its height is changed because of the stretching operation itself.

[WebKit Commit Bot]

Comment on attachment 254483 [details]
Patch

Clearing flags on attachment: 254483

Committed r185327: <http://trac.webkit.org/changeset/185327>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.