We need to provide right timing for custom JS API that may needs to work at the beginning of the page. But we only have two callbacks such as load_started and load_finished both are not able to use this propose. Hence I think we need to provide window_object_cleared callback in EwkPageClient.
Created attachment 254171 [details] patch
Comment on attachment 254171 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=254171&action=review Looks good to me except doxygen improvement. > Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h:62 > + * @param page page that the window object has been cleared We'd better to mention what `window object` means because window is ambiguous. s/window object/JavaScript window object/ or let's add @note for the more description.
Comment on attachment 254171 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=254171&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h:62 >> + * @param page page that the window object has been cleared > > We'd better to mention what `window object` means because window is ambiguous. > s/window object/JavaScript window object/ or let's add @note for the more description. I will change the comment as you mentioned. Thanks.
Comment on attachment 254171 [details] patch LGTM. Please land after fixing the comment ryuan pointed out.
Created attachment 254236 [details] Patch
Created attachment 254237 [details] Patch
Created attachment 254238 [details] Patch
Comment on attachment 254238 [details] Patch Clearing flags on attachment: 254238 Committed r185188: <http://trac.webkit.org/changeset/185188>
All reviewed patches have been landed. Closing bug.