RESOLVED FIXED 145603
[EFL] Implement window_object_cleared callback in EwkPageClient 
https://bugs.webkit.org/show_bug.cgi?id=145603
Summary [EFL] Implement window_object_cleared callback in EwkPageClient
Hyungwook Lee
Reported 2015-06-03 05:23:40 PDT
We need to provide right timing for custom JS API that may needs to work at the beginning of the page. But we only have two callbacks such as load_started and load_finished both are not able to use this propose. Hence I think we need to provide window_object_cleared callback in EwkPageClient.
Attachments
patch (5.20 KB, patch)
2015-06-03 06:13 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
Patch (5.21 KB, patch)
2015-06-03 21:02 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
Patch (5.21 KB, patch)
2015-06-03 21:08 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
Patch (5.21 KB, patch)
2015-06-03 21:21 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Hyungwook Lee
Comment 1 2015-06-03 06:13:14 PDT
Created attachment 254171 [details] patch
Ryuan Choi
Comment 2 2015-06-03 13:53:29 PDT
Comment on attachment 254171 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=254171&action=review Looks good to me except doxygen improvement. > Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h:62 > + * @param page page that the window object has been cleared We'd better to mention what `window object` means because window is ambiguous. s/window object/JavaScript window object/ or let's add @note for the more description.
Hyungwook Lee
Comment 3 2015-06-03 19:44:20 PDT
Comment on attachment 254171 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=254171&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h:62 >> + * @param page page that the window object has been cleared > > We'd better to mention what `window object` means because window is ambiguous. > s/window object/JavaScript window object/ or let's add @note for the more description. I will change the comment as you mentioned. Thanks.
Gyuyoung Kim
Comment 4 2015-06-03 20:39:04 PDT
Comment on attachment 254171 [details] patch LGTM. Please land after fixing the comment ryuan pointed out.
Hyungwook Lee
Comment 5 2015-06-03 21:02:13 PDT
Created attachment 254236 [details] Patch
Hyungwook Lee
Comment 6 2015-06-03 21:08:42 PDT
Created attachment 254237 [details] Patch
Hyungwook Lee
Comment 7 2015-06-03 21:21:27 PDT
Created attachment 254238 [details] Patch
WebKit Commit Bot
Comment 8 2015-06-03 22:14:52 PDT
Comment on attachment 254238 [details] Patch Clearing flags on attachment: 254238 Committed r185188: <http://trac.webkit.org/changeset/185188>
WebKit Commit Bot
Comment 9 2015-06-03 22:14:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.