Bug 145601 - [Streams API] ReadableJSStream does not need a ReadableStreamSource
Summary: [Streams API] ReadableJSStream does not need a ReadableStreamSource
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Depends on:
Blocks: 145640
  Show dependency treegraph
Reported: 2015-06-03 03:05 PDT by youenn fablet
Modified: 2015-06-04 01:53 PDT (History)
4 users (show)

See Also:

Patch (17.56 KB, patch)
2015-06-03 03:18 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (17.62 KB, patch)
2015-06-03 23:50 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-06-03 03:05:29 PDT
ReadableStreamSource was added as a way to define a simple interface for native sources.
This interface is not well suited to JS sources since the code needed to handle JS sources is scattered between ReadableJSStream and ReadableJSStream::Source.

It may be best to remove ReadableStreamSource from ReadableStream and ReadableJSStream.

We would then reintroduce it when supporting native streams as a member of a ReadableNativeStream.
ReadableNativeStream would be the equivalent of ReadableJSStream for native sources.
Comment 1 youenn fablet 2015-06-03 03:18:22 PDT
Created attachment 254164 [details]
Comment 2 Darin Adler 2015-06-03 14:14:38 PDT
Comment on attachment 254164 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=254164&action=review

> Source/WebCore/Modules/streams/ReadableStream.h:87
> +    ReadableStream(ScriptExecutionContext&);

Should add explicit here.
Comment 3 youenn fablet 2015-06-03 23:50:30 PDT
Created attachment 254255 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2015-06-04 00:53:21 PDT
Comment on attachment 254255 [details]
Patch for landing

Clearing flags on attachment: 254255

Committed r185196: <http://trac.webkit.org/changeset/185196>
Comment 5 WebKit Commit Bot 2015-06-04 00:53:24 PDT
All reviewed patches have been landed.  Closing bug.