Bug 145591 - Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
Summary: Web Inspector: Sidebar and sometimes ContentView scroll position is lost when...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-02 21:43 PDT by Joseph Pecoraro
Modified: 2015-06-03 12:19 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.13 KB, patch)
2015-06-02 21:53 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-06-02 21:43:32 PDT
* SUMMARY
Sidebar and sometimes ContentView scroll position is lost when switching between tabs.

* STEPS TO REPRODUCE
1. Inspect <http://apple.com>
2. Show Resources Tab
3. Scroll Resources list to the bottom
4. Switch to Elements tab
5. Switch back to Resources tab
  => Expected Resources list to be scrolled to the bottom

* NOTES
- Repeat with Timeline panel (sidebar / content view are linked)
- Repeat with Details sidebars (non-DOM details sidebar panels, DOM details sidebar panels have their own refresh issues)
Comment 1 Joseph Pecoraro 2015-06-02 21:43:52 PDT
<rdar://problem/21176592>
Comment 2 Joseph Pecoraro 2015-06-02 21:53:20 PDT
Created attachment 254144 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-06-02 21:57:19 PDT
Comment on attachment 254144 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=254144&action=review

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs

How does this fix content view scroll position? I only see sidebar code being changed.
Comment 4 WebKit Commit Bot 2015-06-02 22:47:20 PDT
Comment on attachment 254144 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 254144

Committed r185141: <http://trac.webkit.org/changeset/185141>
Comment 5 WebKit Commit Bot 2015-06-02 22:47:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2015-06-03 12:19:58 PDT
(In reply to comment #3)
> Comment on attachment 254144 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254144&action=review
> 
> > Source/WebInspectorUI/ChangeLog:3
> > +        Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
> 
> How does this fix content view scroll position? I only see sidebar code
> being changed.

In Timelines the sidebar / content view are linked. So scrolling the sidebar just made everything work.