Bug 145578 - Improve test coverage for changes made in 145527
Summary: Improve test coverage for changes made in 145527
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 145527
Blocks:
  Show dependency tree / graph
 
Reported: 2015-06-02 16:33 PDT by Michael Saboff
Modified: 2015-06-03 11:49 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2015-06-02 16:43 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-06-02 16:33:29 PDT 
When the fix for https://bugs.webkit.org/show_bug.cgi?id=145527 was being prepared, it was believed that the bug involved a race between the main thread GC'ing and a worker thread compiling a DFG replacement for a baseline function.  Testing for such a case in a deterministic was considered not worth it.

We should make sure that there is test coverage for most / all of the new paths added.
Comment 1 Michael Saboff 2015-06-02 16:43:42 PDT 
Created attachment 254122 [details]
Patch
Comment 2 Geoffrey Garen 2015-06-03 10:59:40 PDT 
Comment on attachment 254122 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-06-03 11:49:06 PDT 
Comment on attachment 254122 [details]
Patch

Clearing flags on attachment: 254122

Committed r185158: <http://trac.webkit.org/changeset/185158>
Comment 4 WebKit Commit Bot 2015-06-03 11:49:10 PDT 
All reviewed patches have been landed.  Closing bug.