WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145578
Improve test coverage for changes made in 145527
https://bugs.webkit.org/show_bug.cgi?id=145578
Summary
Improve test coverage for changes made in 145527
Michael Saboff
Reported
2015-06-02 16:33:29 PDT
When the fix for
https://bugs.webkit.org/show_bug.cgi?id=145527
was being prepared, it was believed that the bug involved a race between the main thread GC'ing and a worker thread compiling a DFG replacement for a baseline function. Testing for such a case in a deterministic was considered not worth it. We should make sure that there is test coverage for most / all of the new paths added.
Attachments
Patch
(3.37 KB, patch)
2015-06-02 16:43 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2015-06-02 16:43:42 PDT
Created
attachment 254122
[details]
Patch
Geoffrey Garen
Comment 2
2015-06-03 10:59:40 PDT
Comment on
attachment 254122
[details]
Patch r=me
WebKit Commit Bot
Comment 3
2015-06-03 11:49:06 PDT
Comment on
attachment 254122
[details]
Patch Clearing flags on attachment: 254122 Committed
r185158
: <
http://trac.webkit.org/changeset/185158
>
WebKit Commit Bot
Comment 4
2015-06-03 11:49:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug