Bug 145563 – JSExport protocol with an NSInteger property converts negative values to 18446744073709552000

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Keith Miller]

Steps to Reproduce:
My code roughly looks like:

@protocol XXThingExports <JSExport>
@property (nonatomic) NSInteger level;
@end

@interface XXThing : NSObject <XXThingExports>
@property (nonatomic) NSInteger level;
@end

1. From Objective-C, set `level` to a negative value like -46.
2. Accessing the `level` property of an XXThing object from JavaScript gives 18446744073709552000.

Expected Results:
thing.level should be -46

Actual Results:
thing.level is 18446744073709552000

[Keith Miller]

<rdar://problem/19123511>

[Keith Miller]

Created attachment 254089 [details]
The Patch

[Darin Adler]

Comment on attachment 254089 [details]
The Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254089&action=review

> Source/JavaScriptCore/API/tests/testapi.mm:1421
> +@property (nonatomic) NSInteger number;

What if the property is an NSUInteger? Could we add a test case that covers that?

[WebKit Commit Bot]

Comment on attachment 254089 [details]
The Patch

Clearing flags on attachment: 254089

Committed r185122: <http://trac.webkit.org/changeset/185122>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.