RESOLVED FIXED 145558
Add more tests for "should open external urls" flag 
https://bugs.webkit.org/show_bug.cgi?id=145558
Summary Add more tests for "should open external urls" flag
Brady Eidson
Reported 2015-06-02 12:13:14 PDT
Add more tests for "should open external urls" flag Suggested in https://bugs.webkit.org/show_bug.cgi?id=145280
Attachments
Patch v1 (6.63 KB, patch)
2015-06-02 12:37 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-06-02 12:22:57 PDT
In the other bug, Geoff Garen suggested: --- Other interesting test cases: (1) Do a top-level (Safari-like) navigation that sets the flag to true, then another that sets it to false. Flag should be false. (2) Do a top-level (Safari-like) navigation that sets the flag to false, then another that sets it to true. Flag should be true. (3) Do a top-level (Safari-like) navigation that sets the flag to false, then a programmatic click event on a link. Flag should be false.
Brady Eidson
Comment 2 2015-06-02 12:37:15 PDT
Created attachment 254081 [details] Patch v1
Brady Eidson
Comment 3 2015-06-02 12:38:36 PDT
Comment on attachment 254081 [details] Patch v1 Geoff rubber-stamped these in person
Brady Eidson
Comment 4 2015-06-02 12:40:49 PDT
http://trac.webkit.org/changeset/185115
Note You need to log in before you can comment on or make changes to this bug.