Bug 145558 - Add more tests for "should open external urls" flag
Summary: Add more tests for "should open external urls" flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-02 12:13 PDT by Brady Eidson
Modified: 2015-06-02 12:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (6.63 KB, patch)
2015-06-02 12:37 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-06-02 12:13:14 PDT 
Add more tests for "should open external urls" flag

Suggested in https://bugs.webkit.org/show_bug.cgi?id=145280
Comment 1 Brady Eidson 2015-06-02 12:22:57 PDT 
In the other bug, Geoff Garen suggested:
---
Other interesting test cases:

(1) Do a top-level (Safari-like) navigation that sets the flag to true, then another that sets it to false. Flag should be false.

(2) Do a top-level (Safari-like) navigation that sets the flag to false, then another that sets it to true. Flag should be true.

(3) Do a top-level (Safari-like) navigation that sets the flag to false, then a programmatic click event on a link. Flag should be false.
Comment 2 Brady Eidson 2015-06-02 12:37:15 PDT 
Created attachment 254081 [details]
Patch v1
Comment 3 Brady Eidson 2015-06-02 12:38:36 PDT 
Comment on attachment 254081 [details]
Patch v1

Geoff rubber-stamped these in person
Comment 4 Brady Eidson 2015-06-02 12:40:49 PDT 
http://trac.webkit.org/changeset/185115