Bug 145546 - Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
Summary: Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-01 21:16 PDT by Joseph Pecoraro
Modified: 2016-09-07 21:48 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (4.32 KB, patch)
2015-06-01 21:35 PDT, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (5.52 KB, patch)
2015-06-02 12:01 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-06-01 21:16:27 PDT
* SUMMARY:
In the Resources and Debugger tabs, ⌘F no longer brings up find-in-page bar once I start using the quick console.

* STEPS TO REPRODUCE
1. Open a file in the Resources tab.
2. Press ⌘F and observe that a find-in-page bar appears. Click the Done button.
3. Select the quick console and type `window`. Observe that the window object is logged.
4. Return the cursor to the source code editor and press ⌘F again.
  => The find-in-page bar no longer appears.
Comment 1 Joseph Pecoraro 2015-06-01 21:17:10 PDT
<rdar://problem/21189167>
Comment 2 Joseph Pecoraro 2015-06-01 21:35:01 PDT
Created attachment 254048 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-06-01 21:54:36 PDT
Comment on attachment 254048 [details]
[PATCH] Proposed Fix

We don't need to toggle disabled if they are scoped.
Comment 4 Joseph Pecoraro 2015-06-01 22:08:43 PDT
Comment on attachment 254048 [details]
[PATCH] Proposed Fix

Ahh, I agree. We should still enable/disable keyboard shortcuts for the findBanner, but we won't need to for the ContentBrowser. I'll update the patch once the other, conflicting part, lands.
Comment 5 Joseph Pecoraro 2015-06-02 12:01:52 PDT
Created attachment 254076 [details]
[PATCH] For Landing
Comment 6 WebKit Commit Bot 2015-06-02 13:01:05 PDT
The commit-queue encountered the following flaky tests while processing attachment 254076 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2015-06-02 13:01:43 PDT
The commit-queue encountered the following flaky tests while processing attachment 254076 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2015-06-02 14:14:49 PDT
Comment on attachment 254076 [details]
[PATCH] For Landing

Clearing flags on attachment: 254076

Committed r185121: <http://trac.webkit.org/changeset/185121>