RESOLVED FIXED 145524
Add the ability to tell between Catch and Finally blocks 
https://bugs.webkit.org/show_bug.cgi?id=145524
Summary Add the ability to tell between Catch and Finally blocks
Mark Lam
Reported 2015-06-01 13:55:34 PDT
... and also SynthesizedFinally blocks.
Attachments
the patch. (9.98 KB, patch)
2015-06-01 15:44 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Patch for landing (already r+'ed by Michael). (10.25 KB, patch)
2015-06-01 16:20 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-06-01 15:44:55 PDT
Created attachment 254019 [details] the patch.
WebKit Commit Bot
Comment 2 2015-06-01 15:48:05 PDT
Attachment 254019 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:64: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:65: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2015-06-01 15:50:19 PDT
(In reply to comment #2) > ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:64: Please declare enum > bitfields as unsigned integral types. [runtime/enum_bitfields] [5] > ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:65: Please declare enum > bitfields as unsigned integral types. [runtime/enum_bitfields] [5] > Total errors found: 2 in 6 files The style checker is mistaken. I'm already using an unsigned integral type (uint32_t).
Michael Saboff
Comment 4 2015-06-01 16:08:04 PDT
Comment on attachment 254019 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=254019&action=review Continue to use the name popTryAndEmitCatch() as it emits an op_catch bytecode. r=me > Source/JavaScriptCore/ChangeLog:8 > + ... and also SynthesizedFinally blocks too. Add what you mean by "SynthesizedFinally".
Mark Lam
Comment 5 2015-06-01 16:20:01 PDT
Created attachment 254021 [details] Patch for landing (already r+'ed by Michael).
Mark Lam
Comment 6 2015-06-01 16:23:33 PDT
Thanks for the review. Landed in r185083: <http://trac.webkit.org/r185083>.
Note You need to log in before you can comment on or make changes to this bug.