Bug 145524 - Add the ability to tell between Catch and Finally blocks
Summary: Add the ability to tell between Catch and Finally blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 145525
  Show dependency tree / graph
 
Reported: 2015-06-01 13:55 PDT by Mark Lam
Modified: 2015-06-01 16:23 PDT (History)
8 users (show)

See Also:

Attachments
the patch. (9.98 KB, patch)
2015-06-01 15:44 PDT, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
Patch for landing (already r+'ed by Michael). (10.25 KB, patch)
2015-06-01 16:20 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-06-01 13:55:34 PDT 
... and also SynthesizedFinally blocks.
Comment 1 Mark Lam 2015-06-01 15:44:55 PDT 
Created attachment 254019 [details]
the patch.
Comment 2 WebKit Commit Bot 2015-06-01 15:48:05 PDT 
Attachment 254019 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:64:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:65:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-06-01 15:50:19 PDT 
(In reply to comment #2)
> ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:64:  Please declare enum
> bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
> ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:65:  Please declare enum
> bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
> Total errors found: 2 in 6 files

The style checker is mistaken.  I'm already using an unsigned integral type (uint32_t).
Comment 4 Michael Saboff 2015-06-01 16:08:04 PDT 
Comment on attachment 254019 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=254019&action=review

Continue to use the name popTryAndEmitCatch() as it emits an op_catch bytecode.
r=me

> Source/JavaScriptCore/ChangeLog:8
> +        ... and also SynthesizedFinally blocks too.

Add what you mean by "SynthesizedFinally".
Comment 5 Mark Lam 2015-06-01 16:20:01 PDT 
Created attachment 254021 [details]
Patch for landing (already r+'ed by Michael).
Comment 6 Mark Lam 2015-06-01 16:23:33 PDT 
Thanks for the review.  Landed in r185083: <http://trac.webkit.org/r185083>.