Bug 145511 - Fix the webkitpy scm unittests after r174051
Summary: Fix the webkitpy scm unittests after r174051
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 137166 143967
  Show dependency tree / graph
 
Reported: 2015-06-01 05:46 PDT by Csaba Osztrogonác
Modified: 2015-07-08 05:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2015-06-01 05:47 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-01 05:46:06 PDT 
http://trac.webkit.org/changeset/174051 broke the SCM tests
( Tools/Scripts/test-webkitpy -a )

[119/1563] webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch erred:
  Traceback (most recent call last):
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1569, in test_create_patch
      scm = self.make_scm(logging_executive=True)
    File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
      scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
  TypeError: __init__() takes exactly 3 arguments (2 given)

...

r174051 added one more argument to Git.__init__ , but didn't add it to the unittest.
Comment 1 Csaba Osztrogonác 2015-06-01 05:47:37 PDT 
Created attachment 253995 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-01 11:00:28 PDT 
Comment on attachment 253995 [details]
Patch

Clearing flags on attachment: 253995

Committed r185064: <http://trac.webkit.org/changeset/185064>
Comment 3 WebKit Commit Bot 2015-06-01 11:00:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Michael Catanzaro 2015-06-01 11:45:20 PDT 
Were those the only failures you're seeing? I reported a bunch of failures in bug #143967; maybe the others have been fixed somehow.
Comment 5 Csaba Osztrogonác 2015-07-08 05:07:58 PDT 
(In reply to comment #4)
> Were those the only failures you're seeing? I reported a bunch of failures
> in bug #143967; maybe the others have been fixed somehow.

Yes, I have no failure now on Ubuntu 14.04.