Bug 145503 - Explore turning off inlining of functions that haven't made it to Baseline
Summary: Explore turning off inlining of functions that haven't made it to Baseline
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-31 11:02 PDT by Filip Pizlo
Modified: 2017-12-01 10:31 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-05-31 11:02:28 PDT 
...
Comment 1 Robin Morisset 2017-12-01 10:31:32 PST 
I have started experimenting with this.
It provided a very small, barely significant (when lucky and there is very low noise in the benchmark) speed-up of about 0.5% on the old jsc-only benchmarks (Octane, Kraken, Sunspider).

I would like to do more thorough benchmarking, including ARES/Speedometer before landing this change.

I have also tested scaling the inliningCost by the tier reached by the callee (encouraging inlining of very hot functions, and discouraging inlining of very cold ones). So far it has not seemed to bring any measurable additional improvement.