Bug 145496 - Any exit from any JIT due to profiling for an inline cache should force all future compilations to be wary
Summary: Any exit from any JIT due to profiling for an inline cache should force all f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-30 22:34 PDT by Filip Pizlo
Modified: 2015-06-01 22:41 PDT (History)
12 users (show)

See Also:

Attachments
the patch (8.71 KB, patch)
2015-05-30 22:36 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-05-30 22:34:46 PDT 
Previously we had this thing where the FTL would ignore non-FTL exit sites.  That seemed like a good idea at the time, but there are some pathologies that we found in Speedometer where this isn't so good.  For example we might have an exit from the DFG that happened just after the FTL compilation was enqueued.
Comment 1 Filip Pizlo 2015-05-30 22:36:49 PDT 
Created attachment 253972 [details]
the patch
Comment 2 Geoffrey Garen 2015-06-01 13:09:04 PDT 
Comment on attachment 253972 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253972&action=review

r=me

Is this a Speedometer speedup?

> Source/JavaScriptCore/ChangeLog:3
> +        Any exit from any JIT due to profiling for an inline cache should force all future compilations to be weary

I think you meant "wary".
Comment 3 Filip Pizlo 2015-06-01 22:41:26 PDT 
Landed in http://trac.webkit.org/changeset/185103