Bug 145495 - Make FrameLoader methods that take PassRefPtr<Event> take raw pointers instead
Summary: Make FrameLoader methods that take PassRefPtr<Event> take raw pointers instead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-30 21:21 PDT by Brady Eidson
Modified: 2015-06-01 10:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (10.21 KB, patch)
2015-05-30 21:23 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-05-30 21:21:34 PDT 
Make FrameLoader methods that take PassRefPtr<Event> take raw pointers instead

Ownership of the event is rarely actually being transferred, and the code paths are definitely not hot, so we're not actually worried about ref churn.

But this will make the related code cleaner and less likely to run across bizarre correctness issues like that found in https://bugs.webkit.org/show_bug.cgi?id=145472 and fixed in http://trac.webkit.org/changeset/185033
Comment 1 Brady Eidson 2015-05-30 21:23:54 PDT 
Created attachment 253970 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-05-30 22:53:28 PDT 
Comment on attachment 253970 [details]
Patch v1

Clearing flags on attachment: 253970

Committed r185037: <http://trac.webkit.org/changeset/185037>
Comment 3 WebKit Commit Bot 2015-05-30 22:53:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2015-06-01 10:10:09 PDT 
Comment on attachment 253970 [details]
Patch v1

These should be references unless the event can be null.
Comment 5 Brady Eidson 2015-06-01 10:18:34 PDT 
(In reply to comment #4)
> Comment on attachment 253970 [details]
> Patch v1
> 
> These should be references unless the event can be null.

The event can be null.