Bug 145493 – PDFs always think they're visible on iOS.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gavin Barraclough]

The problem here is that WKContentView is currently responsible for notifying the WebPageProxy that the visibility may have changed, but when a PDF isn't showing the WKContentView isn't in the view hierarchy and doesn't receive the didMoveToWindow notifications – and the WKPDFView (which is in the view hierarchy) does not listen for these events.

Visibility of the page should really just track the visibility of the WKWebView (and when actually assessing the visibility it largely does - the page client checks the web view's visibility, bar a FIXME, and the foreground/background check, which needs to change). So notifications should really just come from the WKWebView.

The WKWebView already listens for the didMoveToWindow notification, it just was only updating the IsInWindow flag. Instead just update all flags, and the call to viewStateDidChange from WKContentView can just be removed.

There is one problem with this in that it would reverse the order of the calls to viewStateDidChange & _updateForScreen:, which would mean the the view would become visible before updating the screen pixel density. To fix this, moving the call to _updateForScreen: to willMoveToWindow:, to ensure it occurs before the page becomes visible.

This will also change behavior on Mac for WKWebView clients, in coalescing all view state changes within the didMoveToWindow call. This is the direction we intended to go in anyway (the plan is to remove the mayHaveChanged argument from viewStateDidChange - we're currently adding unnecessary IPC traffic).

[Gavin Barraclough]

Created attachment 253964 [details]
Fix

[Andreas Kling]

Comment on attachment 253964 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253964&action=review

r=me

> Source/WebKit2/ChangeLog:25
> +        updating the screen pixel density. To fix this, moving the call to _updateForScreen:

s/moving/move/

[Gavin Barraclough]

Committed revision 185046.

[Daniel Bates]

(In reply to comment #3)
> Committed revision 185046.

This change causes many animation tests to time out on iOS WebKit2.

[Gavin Barraclough]

Temporary roll-out in r185068...

[Gavin Barraclough]

Created attachment 254107 [details]
With fix for WebKitTestRunner

[Gavin Barraclough]

Comment on attachment 254107 [details]
With fix for WebKitTestRunner

Reviewed by Sam.

[Gavin Barraclough]

Committed revision 185127.