Bug 145476 - WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type)
Summary: WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-29 15:25 PDT by Anders Carlsson
Modified: 2017-02-09 17:18 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.90 KB, patch)
2015-05-29 15:26 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-05-29 15:25:30 PDT 
WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type)
Comment 1 Anders Carlsson 2015-05-29 15:26:09 PDT 
Created attachment 253925 [details]
Patch
Comment 2 Anders Carlsson 2015-05-29 15:33:24 PDT 
Committed r185010: <http://trac.webkit.org/changeset/185010>
Comment 3 Darin Adler 2015-05-29 15:36:27 PDT 
So the NSInteger typedef comes from the <TargetAvailability.h> header? Seriously?
Comment 4 Anders Carlsson 2015-05-29 15:44:46 PDT 
(In reply to comment #3)
> So the NSInteger typedef comes from the <TargetAvailability.h> header?
> Seriously?

No, there is no WebNSInteger typedef. The reason this builds is that nobody ends up defining TARGET_OS_IPHONE

(It's actually quite possible that nobody even imports WebResourceLoadDelegatePrivate.h at all)
Comment 5 Darin Adler 2015-05-30 16:11:10 PDT 
I was asking about NSInteger, not WebNSInteger, but I guess the include is for TARGET_OS_IPHONE?
Comment 6 Anders Carlsson 2015-06-01 10:14:18 PDT 
(In reply to comment #5)
> I was asking about NSInteger, not WebNSInteger, but I guess the include is
> for TARGET_OS_IPHONE?

Ah, yes it is. (I didn't want to mess with the includes more than necessary).