Bug 145474 - Web Inspector: Resources tab navigation sidebar should have a type filter header
Summary: Web Inspector: Resources tab navigation sidebar should have a type filter header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-29 14:56 PDT by Timothy Hatcher
Modified: 2015-05-31 12:50 PDT (History)
7 users (show)

See Also:

Attachments
Screenshot with Patch (36.46 KB, image/png)
2015-05-29 14:56 PDT, Timothy Hatcher 		no flags Details
Patch (37.47 KB, patch)
2015-05-29 15:02 PDT, Timothy Hatcher 		joepeck: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-05-29 14:56:51 PDT 
Created attachment 253920 [details]
Screenshot with Patch

The filter would filter by resource type and make the sidebar look better aligned with the navigation bar of the content browser.
Comment 1 Radar WebKit Bug Importer 2015-05-29 14:57:00 PDT 
<rdar://problem/21166032>
Comment 2 Timothy Hatcher 2015-05-29 15:02:04 PDT 
Created attachment 253921 [details]
Patch
Comment 3 Joseph Pecoraro 2015-05-29 18:11:38 PDT 
Comment on attachment 253921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253921&action=review

r=me

> Source/WebInspectorUI/ChangeLog:81
> +2015-05-29  Timothy Hatcher  <timothy@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).

Double changelog!

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2015.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:47
> +            scopeBarItem.__resourceType = value;

Should we use a Symbol instead of __foo? I'm fine either way, I think the __foo is easier to type then using a Symbol.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:187
> +        var selectedScopBarItem = this._scopeBar.selectedItems[0];

Typo: Variable name "selectedScopBarItem" => "selectedScopeBarItem"

> Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:71
> +        this._itemsById = {};

Map?
Comment 4 Timothy Hatcher 2015-05-31 12:50:58 PDT 
https://trac.webkit.org/r185044