RESOLVED FIXED 145474
Web Inspector: Resources tab navigation sidebar should have a type filter header 
https://bugs.webkit.org/show_bug.cgi?id=145474
Summary Web Inspector: Resources tab navigation sidebar should have a type filter header
Timothy Hatcher
Reported 2015-05-29 14:56:51 PDT
Created attachment 253920 [details] Screenshot with Patch The filter would filter by resource type and make the sidebar look better aligned with the navigation bar of the content browser.
Attachments
Screenshot with Patch (36.46 KB, image/png)
2015-05-29 14:56 PDT, Timothy Hatcher 		no flags
Details
Patch (37.47 KB, patch)
2015-05-29 15:02 PDT, Timothy Hatcher 		joepeck: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-29 14:57:00 PDT
<rdar://problem/21166032>
Timothy Hatcher
Comment 2 2015-05-29 15:02:04 PDT
Created attachment 253921 [details] Patch
Joseph Pecoraro
Comment 3 2015-05-29 18:11:38 PDT
Comment on attachment 253921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253921&action=review r=me > Source/WebInspectorUI/ChangeLog:81 > +2015-05-29 Timothy Hatcher <timothy@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). Double changelog! > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. 2015. > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:47 > + scopeBarItem.__resourceType = value; Should we use a Symbol instead of __foo? I'm fine either way, I think the __foo is easier to type then using a Symbol. > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:187 > + var selectedScopBarItem = this._scopeBar.selectedItems[0]; Typo: Variable name "selectedScopBarItem" => "selectedScopeBarItem" > Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:71 > + this._itemsById = {}; Map?
Timothy Hatcher
Comment 4 2015-05-31 12:50:58 PDT
https://trac.webkit.org/r185044
Note You need to log in before you can comment on or make changes to this bug.