Bug 145462 – Add stub implementation of MediaRemoteControls, part of Media Session spec

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

Add a stub implementation of MediaRemoteControls, part of the Media Session spec: https://mediasession.spec.whatwg.org/

[Radar WebKit Bug Importer]

<rdar://problem/21162651>

[Matt Rajca]

Created attachment 253923 [details]
Patch

[Conrad Shultz]

Comment on attachment 253923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review

> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29
> +#if ENABLE(MEDIA_SESSION)

Would it make sense for this to be above the includes?

[Eric Carlson]

Comment on attachment 253923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review

>> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29
>> +#if ENABLE(MEDIA_SESSION)
> 
> Would it make sense for this to be above the includes?

This is the pattern typically used throughout WebKit.

> Source/WebCore/Modules/mediasession/MediaRemoteControls.h:53
> +    virtual ~MediaRemoteControls();

Does the destructor need to be public?

[Matt Rajca]

Created attachment 254008 [details]
Patch (re-based)

[Matt Rajca]

The destructor needs to be visible to the public `deref` method (not sure why inline comments I make on the original patch don't show up here like everyone else's).

I attached a re-based patch.

[WebKit Commit Bot]

Comment on attachment 254008 [details]
Patch (re-based)

Clearing flags on attachment: 254008

Committed r185069: <http://trac.webkit.org/changeset/185069>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.