Bug 145462 - Add stub implementation of MediaRemoteControls, part of Media Session spec
Summary: Add stub implementation of MediaRemoteControls, part of Media Session spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-05-29 12:03 PDT by Matt Rajca
Modified: 2015-06-01 12:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.58 KB, patch)
2015-05-29 15:11 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (re-based) (15.64 KB, patch)
2015-06-01 10:46 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-05-29 12:03:03 PDT 
Add a stub implementation of MediaRemoteControls, part of the Media Session spec: https://mediasession.spec.whatwg.org/
Comment 1 Radar WebKit Bug Importer 2015-05-29 12:05:05 PDT 
<rdar://problem/21162651>
Comment 2 Matt Rajca 2015-05-29 15:11:31 PDT 
Created attachment 253923 [details]
Patch
Comment 3 Conrad Shultz 2015-05-31 15:59:15 PDT 
Comment on attachment 253923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review

> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29
> +#if ENABLE(MEDIA_SESSION)

Would it make sense for this to be above the includes?
Comment 4 Eric Carlson 2015-06-01 06:43:54 PDT 
Comment on attachment 253923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review

>> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29
>> +#if ENABLE(MEDIA_SESSION)
> 
> Would it make sense for this to be above the includes?

This is the pattern typically used throughout WebKit.

> Source/WebCore/Modules/mediasession/MediaRemoteControls.h:53
> +    virtual ~MediaRemoteControls();

Does the destructor need to be public?
Comment 5 Matt Rajca 2015-06-01 10:46:08 PDT 
Created attachment 254008 [details]
Patch (re-based)
Comment 6 Matt Rajca 2015-06-01 10:50:50 PDT 
The destructor needs to be visible to the public `deref` method (not sure why inline comments I make on the original patch don't show up here like everyone else's).

I attached a re-based patch.
Comment 7 WebKit Commit Bot 2015-06-01 12:06:07 PDT 
Comment on attachment 254008 [details]
Patch (re-based)

Clearing flags on attachment: 254008

Committed r185069: <http://trac.webkit.org/changeset/185069>
Comment 8 WebKit Commit Bot 2015-06-01 12:06:11 PDT 
All reviewed patches have been landed.  Closing bug.