Bug 145459 - Small FrameLoader refactoring
Summary: Small FrameLoader refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-29 09:11 PDT by Brady Eidson
Modified: 2015-05-29 09:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (7.63 KB, patch)
2015-05-29 09:14 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-05-29 09:11:55 PDT 
Small FrameLoader refactoring

A couple of the load methods take a whole bunch of arguments broken out from a FrameLoadRequest.
The callers already *have* a FrameLoadRequest.

They should just pass along the entire FrameLoadRequest.
Comment 1 Brady Eidson 2015-05-29 09:14:33 PDT 
Created attachment 253902 [details]
Patch v1
Comment 2 Alex Christensen 2015-05-29 09:26:14 PDT 
Comment on attachment 253902 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=253902&action=review

lgtm except one thing:

> Source/WebCore/loader/FrameLoader.cpp:918
> +    FrameLoadRequest frameLoadRequest(m_frame.document()->securityOrigin(), ResourceRequest(url), "_self", LockHistory::No, LockBackForwardList::No, ShouldSendReferrer::MaybeSendReferrer, AllowNavigationToInvalidURL::Yes, NewFrameOpenerPolicy::Suppress, ReplaceDocumentIfJavaScriptURL);

I think this should have LockBackForwardList::Yes instead of no.
Comment 3 Brady Eidson 2015-05-29 09:32:22 PDT 
http://trac.webkit.org/changeset/184987