Bug 145448 - Web Inspector: NewTabContentView should update button disabled state as other tabs are added/removed
Summary: Web Inspector: NewTabContentView should update button disabled state as other...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-28 15:54 PDT by Joseph Pecoraro
Modified: 2015-09-15 11:27 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.14 KB, patch)
2015-05-28 15:56 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (3.96 KB, patch)
2015-05-28 16:16 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-28 15:54:00 PDT 
* SUMMARY
NewTabContentView should update button disabled state as other tabs are added/removed

* STEPS TO REPRODUCE
1. Open inspector
2. Open Elements and Resources tab
3. Open New Tab tab
4. Close Elements tab
  => New tab tab should allow creating an Elements tab, currently the button is disabled
Comment 1 Radar WebKit Bug Importer 2015-05-28 15:54:21 PDT 
<rdar://problem/21149911>
Comment 2 Joseph Pecoraro 2015-05-28 15:56:42 PDT 
Created attachment 253872 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-05-28 16:11:53 PDT 
Comment on attachment 253872 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253872&action=review

Nice! I wasn't sure we would need this. Not really intended for you to keep the New Tab open.

> Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:85
> +        WebInspector.tabBrowser.tabBar.removeEventListener(WebInspector.TabBar.Event.TabBarItemAdded, this._updateTabItems, this);
> +        WebInspector.tabBrowser.tabBar.removeEventListener(WebInspector.TabBar.Event.TabBarItemRemoved, this._updateTabItems, this);

WebInspector.tabBrowser.tabBar.removeEventListener(null, null, this);
Comment 4 Joseph Pecoraro 2015-05-28 16:16:44 PDT 
Created attachment 253874 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2015-05-28 17:19:31 PDT 
The commit-queue encountered the following flaky tests while processing attachment 253874 [details]:

compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2015-05-28 17:20:59 PDT 
Comment on attachment 253874 [details]
[PATCH] For Landing

Clearing flags on attachment: 253874

Committed r184971: <http://trac.webkit.org/changeset/184971>