Bug 145448 – Web Inspector: NewTabContentView should update button disabled state as other tabs are added/removed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
NewTabContentView should update button disabled state as other tabs are added/removed

* STEPS TO REPRODUCE
1. Open inspector
2. Open Elements and Resources tab
3. Open New Tab tab
4. Close Elements tab
  => New tab tab should allow creating an Elements tab, currently the button is disabled

[Radar WebKit Bug Importer]

<rdar://problem/21149911>

[Joseph Pecoraro]

Created attachment 253872 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 253872 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253872&action=review

Nice! I wasn't sure we would need this. Not really intended for you to keep the New Tab open.

> Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:85
> +        WebInspector.tabBrowser.tabBar.removeEventListener(WebInspector.TabBar.Event.TabBarItemAdded, this._updateTabItems, this);
> +        WebInspector.tabBrowser.tabBar.removeEventListener(WebInspector.TabBar.Event.TabBarItemRemoved, this._updateTabItems, this);

WebInspector.tabBrowser.tabBar.removeEventListener(null, null, this);

[Joseph Pecoraro]

Created attachment 253874 [details]
[PATCH] For Landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 253874 [details]:

compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 253874 [details]
[PATCH] For Landing

Clearing flags on attachment: 253874

Committed r184971: <http://trac.webkit.org/changeset/184971>