RESOLVED FIXED 145441
Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo 
https://bugs.webkit.org/show_bug.cgi?id=145441
Summary Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Basile Clement
Reported 2015-05-28 11:00:50 PDT
Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Attachments
Patch (2.83 KB, patch)
2015-05-28 11:02 PDT, Basile Clement 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2015-05-28 11:21 PDT, Basile Clement 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basile Clement
Comment 1 2015-05-28 11:02:36 PDT
Created attachment 253850 [details] Patch
Mark Lam
Comment 2 2015-05-28 11:13:58 PDT
Comment on attachment 253850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253850&action=review > Source/JavaScriptCore/dfg/DFGNode.h:2008 > { Did you intend to add an ASSERT(hasTypeLocation()) here?
Basile Clement
Comment 3 2015-05-28 11:20:46 PDT
(In reply to comment #2) > Comment on attachment 253850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253850&action=review > > > Source/JavaScriptCore/dfg/DFGNode.h:2008 > > { > > Did you intend to add an ASSERT(hasTypeLocation()) here? Oops, indeed. Updating the patch.
Basile Clement
Comment 4 2015-05-28 11:21:33 PDT
Created attachment 253852 [details] Patch
Basile Clement
Comment 5 2015-05-28 12:14:46 PDT
Committed r184958: <http://trac.webkit.org/changeset/184958>
Note You need to log in before you can comment on or make changes to this bug.