Bug 145441 - Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Summary: Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basile Clement
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-28 11:00 PDT by Basile Clement
Modified: 2015-05-28 12:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2015-05-28 11:02 PDT, Basile Clement 		no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2015-05-28 11:21 PDT, Basile Clement 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basile Clement 2015-05-28 11:00:50 PDT 
Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Comment 1 Basile Clement 2015-05-28 11:02:36 PDT 
Created attachment 253850 [details]
Patch
Comment 2 Mark Lam 2015-05-28 11:13:58 PDT 
Comment on attachment 253850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253850&action=review

> Source/JavaScriptCore/dfg/DFGNode.h:2008
>      {

Did you intend to add an ASSERT(hasTypeLocation()) here?
Comment 3 Basile Clement 2015-05-28 11:20:46 PDT 
(In reply to comment #2)
> Comment on attachment 253850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253850&action=review
> 
> > Source/JavaScriptCore/dfg/DFGNode.h:2008
> >      {
> 
> Did you intend to add an ASSERT(hasTypeLocation()) here?

Oops, indeed. Updating the patch.
Comment 4 Basile Clement 2015-05-28 11:21:33 PDT 
Created attachment 253852 [details]
Patch
Comment 5 Basile Clement 2015-05-28 12:14:46 PDT 
Committed r184958: <http://trac.webkit.org/changeset/184958>