Bug 145416 - Web Inspector: Toggling an inherited property sometimes stops working
Summary: Web Inspector: Toggling an inherited property sometimes stops working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-27 15:16 PDT by Joseph Pecoraro
Modified: 2015-05-27 18:52 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.06 KB, patch)
2015-05-27 15:19 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-27 15:16:48 PDT 
* SUMMARY
Toggling an inherited property sometimes stops working.

* TEST
<!DOCTYPE html>
<html>
<head>
    <style>
    body { color: blue; }
    p { color: red; }
    </style>
</head>
<body>
    <p>Lorem ipsum dolor sit amet, consectetur adipisicing elit.</p>
</body>
</html>

* STEPS TO REPRODUCE
1. Inspect <p>
2. Show Styles > Rules
3. Click checkbox to toggle the inherited "color: blue" to a comment
4. Click checkbox to try to untoggle the comment
  => doesn't work, and occasionally this editor will revert back to uncommented but not match the page

* NOTES
- Inherited CSSStyleProperty is not getting updated properly despite good matchedCSSRules data
Comment 1 Joseph Pecoraro 2015-05-27 15:17:25 PDT 
<rdar://problem/20892784>
Comment 2 Joseph Pecoraro 2015-05-27 15:19:20 PDT 
Created attachment 253803 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-05-27 18:51:59 PDT 
Comment on attachment 253803 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253803

Committed r184934: <http://trac.webkit.org/changeset/184934>
Comment 4 WebKit Commit Bot 2015-05-27 18:52:02 PDT 
All reviewed patches have been landed.  Closing bug.