Bug 145399 – Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

In Elements > Styles > Rules, it is possible to highlight one section (such as the CSS applied to the "body") and then highlight another section (such as a specific div element) without de-highlighting the first section.  In a section with highlighted content, the only way to de-highlight that content is to click again within that section.  Clicking outside that section will not effect the highlighted content in any way.  It should instead be that clicking outside of one section will de-highlight all content in any other content so that only one piece of content is highlighted/selected at any given time.

[Radar WebKit Bug Importer]

<rdar://problem/21116228>

[Devin Rousso]

Created attachment 254102 [details]
Patch

[Timothy Hatcher]

Comment on attachment 254102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254102&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:287
> +        this._delegate.editorFocused(this);

This should check for existence of the auction before calling it. This would also be "cssStyleDeclarationSectionEditorFocused".

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:73
> +        if (typeof this._delegate.editorFocused === "function")

Delegate methods should be prefixed with the class name, so they can't conflict with others or built-in methods. So this should be "cssStyleDeclarationTextEditorFocused" to match the other delegate methods on this class.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:330
> +        if (typeof this._delegate.editorFocused === "function")
> +            this._delegate.editorFocused();

Ditto.

> Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js:260
> +    editorFocused(ignoredSection)

This would be cssStyleDeclarationSectionEditorFocused.

[Devin Rousso]

Created attachment 254391 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254391 [details]
Patch

Clearing flags on attachment: 254391

Committed r185279: <http://trac.webkit.org/changeset/185279>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.