Bug 145379 - Try to use StringView when comparing JSStrings for equality.
Summary: Try to use StringView when comparing JSStrings for equality.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on: 145456
Blocks:
  Show dependency tree / graph
 
Reported: 2015-05-26 08:50 PDT by Andreas Kling
Modified: 2015-05-29 00:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2015-05-26 08:50 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-26 08:50:08 PDT 
Checking two JSStrings for equality should use StringView to avoid reifying substrings.
Comment 1 Andreas Kling 2015-05-26 08:50:32 PDT 
Created attachment 253705 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-26 10:28:47 PDT 
Comment on attachment 253705 [details]
Patch

Clearing flags on attachment: 253705

Committed r184860: <http://trac.webkit.org/changeset/184860>
Comment 3 WebKit Commit Bot 2015-05-26 10:28:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Yusuke Suzuki 2015-05-29 00:38:40 PDT 
Hi, kling. What do you think about it?
https://bugs.webkit.org/show_bug.cgi?id=145360
Comment 5 WebKit Commit Bot 2015-05-29 00:43:54 PDT 
Re-opened since this is blocked by bug 145456