RESOLVED FIXED145351
String.prototype.indexOf() should use StringView. 
https://bugs.webkit.org/show_bug.cgi?id=145351
Summary String.prototype.indexOf() should use StringView.
Andreas Kling
Reported 2015-05-23 13:50:43 PDT
We can avoid creating new StringImpls in indexOf() if we use JSString::view() to search through the string. This requires adding a StringView::find(StringView, start) implementation.
Attachments
Patch (10.18 KB, patch)
2015-05-23 13:55 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2015-06-08 22:15 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-23 13:55:32 PDT
Created attachment 253650 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-26 11:57:31 PDT
Comment on attachment 253650 [details] Patch Clearing flags on attachment: 253650 Committed r184867: <http://trac.webkit.org/changeset/184867>
WebKit Commit Bot
Comment 3 2015-05-26 11:57:36 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 4 2015-06-08 22:07:19 PDT
Re-opening to attach the StringPrototype parts, too. (Duh.)
Andreas Kling
Comment 5 2015-06-08 22:15:00 PDT
Created attachment 254547 [details] Patch
WebKit Commit Bot
Comment 6 2015-06-09 11:02:17 PDT
Comment on attachment 254547 [details] Patch Clearing flags on attachment: 254547 Committed r185367: <http://trac.webkit.org/changeset/185367>
WebKit Commit Bot
Comment 7 2015-06-09 11:02:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.