Bug 145343 - CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
Summary: CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-22 23:46 PDT by Joseph Pecoraro
Modified: 2016-04-28 12:42 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.15 KB, patch)
2015-05-22 23:47 PDT, Joseph Pecoraro
timothy: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (560.01 KB, application/zip)
2015-05-23 00:21 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (583.79 KB, application/zip)
2015-05-23 00:42 PDT, Build Bot
no flags Details
[PATCH] For Landing (7.62 KB, patch)
2015-05-26 11:38 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-22 23:46:10 PDT
* SUMMARY
CSS properties (font-synthesis, column-fill) are missing in getComputedStyles.

  font-synthesis
  column-fill

Adding them to the list will ensure they show up in the Computed Properties section of Web Inspector.
Comment 1 Joseph Pecoraro 2015-05-22 23:47:10 PDT
Created attachment 253641 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2015-05-23 00:21:47 PDT
Comment on attachment 253641 [details]
[PATCH] Proposed Fix

Attachment 253641 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4516166961725440

New failing tests:
svg/css/getComputedStyle-basic.xhtml
Comment 3 Build Bot 2015-05-23 00:21:53 PDT
Created attachment 253642 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-05-23 00:42:24 PDT
Comment on attachment 253641 [details]
[PATCH] Proposed Fix

Attachment 253641 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5889725420273664

New failing tests:
svg/css/getComputedStyle-basic.xhtml
Comment 5 Build Bot 2015-05-23 00:42:28 PDT
Created attachment 253643 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Joseph Pecoraro 2015-05-26 11:38:04 PDT
Created attachment 253713 [details]
[PATCH] For Landing
Comment 7 WebKit Commit Bot 2015-05-26 12:50:34 PDT
Comment on attachment 253713 [details]
[PATCH] For Landing

Clearing flags on attachment: 253713

Committed r184869: <http://trac.webkit.org/changeset/184869>