Bug 145339 - Rationalize the behavior when timing out touch event dispatch
Summary: Rationalize the behavior when timing out touch event dispatch
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-22 22:01 PDT by Benjamin Poulain
Modified: 2016-08-02 15:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.60 KB, patch)
2015-05-22 22:06 PDT, Benjamin Poulain 		bfulgham: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-05-22 22:01:33 PDT 
Rationalize the behavior when timing out touch event dispatch
Comment 1 Benjamin Poulain 2015-05-22 22:06:19 PDT 
Created attachment 253636 [details]
Patch
Comment 2 Sam Weinig 2015-06-08 17:31:44 PDT 
Comment on attachment 253636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253636&action=review

> Source/WebKit2/Shared/WebEvent.h:415
> +    bool hasEventDeliveryTimedOut() const { return m_eventDeliveryTimedOut; }
> +    void eventDeliveryTimedOut() { m_eventDeliveryTimedOut = true; }

I've been trying to keep these platform Event objects immutable so far. Is there another design that doesn't force mutability here?
Comment 3 Benjamin Poulain 2015-06-08 17:59:16 PDT 
(In reply to comment #2)
> Comment on attachment 253636 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253636&action=review
> 
> > Source/WebKit2/Shared/WebEvent.h:415
> > +    bool hasEventDeliveryTimedOut() const { return m_eventDeliveryTimedOut; }
> > +    void eventDeliveryTimedOut() { m_eventDeliveryTimedOut = true; }
> 
> I've been trying to keep these platform Event objects immutable so far. Is
> there another design that doesn't force mutability here?

Sure. I don't have to put that information on the event, it can be an additional structure passed along to the WebProcess.

Would that be okay with you?
Comment 4 Sam Weinig 2015-06-08 18:15:57 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 253636 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=253636&action=review
> > 
> > > Source/WebKit2/Shared/WebEvent.h:415
> > > +    bool hasEventDeliveryTimedOut() const { return m_eventDeliveryTimedOut; }
> > > +    void eventDeliveryTimedOut() { m_eventDeliveryTimedOut = true; }
> > 
> > I've been trying to keep these platform Event objects immutable so far. Is
> > there another design that doesn't force mutability here?
> 
> Sure. I don't have to put that information on the event, it can be an
> additional structure passed along to the WebProcess.
> 
> Would that be okay with you?

Yeah, that sounds great!
Comment 5 Brent Fulgham 2016-03-10 10:34:04 PST 
Comment on attachment 253636 [details]
Patch

It sounds like Sam wants you to make changes to the implementation, so I'll r- this to get it our of the review queue.
Comment 6 Simon Fraser (smfr) 2016-08-02 15:06:08 PDT 
rdar://problem/27666110