Bug 145335 - Web Inspector: Adopt Object.setPrototypeOf
Summary: Web Inspector: Adopt Object.setPrototypeOf
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-05-22 20:48 PDT by Joseph Pecoraro
Modified: 2015-05-22 23:31 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.96 KB, patch)
2015-05-22 20:49 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (1.38 KB, patch)
2015-05-22 21:06 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-22 20:48:28 PDT 
* SUMMARY
Adopt Object.setPrototypeOf and provide better API view for it.

Just implemented in JavaScriptCore. For the one place where we set __proto__ that won't easily be converted to ES6 classes, we can use the method. And remember to improve the parameter list for the API view.
Comment 1 Joseph Pecoraro 2015-05-22 20:49:30 PDT 
Created attachment 253630 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2015-05-22 21:04:41 PDT 
I'm going to update Native parameter lists separately. Just focus on adoption here.
Comment 3 Joseph Pecoraro 2015-05-22 21:06:00 PDT 
Created attachment 253631 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2015-05-22 23:31:15 PDT 
Comment on attachment 253631 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253631

Committed r184820: <http://trac.webkit.org/changeset/184820>
Comment 5 WebKit Commit Bot 2015-05-22 23:31:19 PDT 
All reviewed patches have been landed.  Closing bug.