Bug 145329 - Clean up logic for updating caps lock indicator state
Summary: Clean up logic for updating caps lock indicator state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-22 16:58 PDT by Daniel Bates
Modified: 2015-05-29 16:59 PDT (History)
0 users

See Also:

Attachments
Patch (4.68 KB, patch)
2015-05-22 17:00 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-05-22 16:58:15 PDT 
We can take advantage of the fact that the caps lock indicator is implemented in the shadow DOM to simplify the logic for updating its state. Notice that TextFieldInputType listens for DOM focus and DOM blur events and updates the state of the caps lock indicator. It's unnecessary to explicitly update the state of the caps lock indicator using EventHandler::capsLockStateMayHaveChanged().
Comment 1 Daniel Bates 2015-05-22 17:00:39 PDT 
Created attachment 253618 [details]
Patch
Comment 2 Daniel Bates 2015-05-29 16:59:43 PDT 
Comment on attachment 253618 [details]
Patch

Clearing flags on attachment: 253618

Committed r185020: <http://trac.webkit.org/changeset/185020>
Comment 3 Daniel Bates 2015-05-29 16:59:46 PDT 
All reviewed patches have been landed.  Closing bug.