WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145329
Clean up logic for updating caps lock indicator state
https://bugs.webkit.org/show_bug.cgi?id=145329
Summary
Clean up logic for updating caps lock indicator state
Daniel Bates
Reported
2015-05-22 16:58:15 PDT
We can take advantage of the fact that the caps lock indicator is implemented in the shadow DOM to simplify the logic for updating its state. Notice that TextFieldInputType listens for DOM focus and DOM blur events and updates the state of the caps lock indicator. It's unnecessary to explicitly update the state of the caps lock indicator using EventHandler::capsLockStateMayHaveChanged().
Attachments
Patch
(4.68 KB, patch)
2015-05-22 17:00 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2015-05-22 17:00:39 PDT
Created
attachment 253618
[details]
Patch
Daniel Bates
Comment 2
2015-05-29 16:59:43 PDT
Comment on
attachment 253618
[details]
Patch Clearing flags on attachment: 253618 Committed
r185020
: <
http://trac.webkit.org/changeset/185020
>
Daniel Bates
Comment 3
2015-05-29 16:59:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug