Bug 145312 – Yellow highlight and DD popover don't go away when scrolling an iframe

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Yellow highlight and DD popover don't go away when scrolling an iframe

rdar://problem/19692334

[Beth Dakin]

Created attachment 253600 [details]
Patch

[Tim Horton]

Comment on attachment 253600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253600&action=review

> Source/WebKit2/ChangeLog:11
> +        Match what Lookup already does for their popover and dismiss our popovers on 
> +        scroll.

We could probably get rid of the other way they're dismissed on scroll, now, if we want.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1351
> +    [self _dismissContentRelativeChildWindowsWithAnimation:NO];

You should make sure this isn't too expensive. I think everything checks and short-circuits if there isn't currently anything installed, but ... double check?

[Beth Dakin]

Created attachment 253603 [details]
Patch

[Tim Horton]

Comment on attachment 253603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253603&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:-3689
> -    m_pageClient.dismissContentRelativeChildWindows(false);

Are there other callers of this page client method? (there probably are, just checking)

[Beth Dakin]

(In reply to comment #4)
> Comment on attachment 253603 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253603&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:-3689
> > -    m_pageClient.dismissContentRelativeChildWindows(false);
> 
> Are there other callers of this page client method? (there probably are,
> just checking)

There are other callers, but good thought!

http://trac.webkit.org/changeset/184790