Bug 145290 - CPS rethreading should really get rid of GetLocals
Summary: CPS rethreading should really get rid of GetLocals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-21 18:45 PDT by Filip Pizlo
Modified: 2015-05-21 23:33 PDT (History)
13 users (show)

See Also:

Attachments
the patch (4.77 KB, patch)
2015-05-21 18:49 PDT, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-05-21 18:45:23 PDT 
This is benign right now because CSE gets rid of redundant GetLocals already.  But, the idea is that CSE should not be mandatory.  CPS rethreading should do it right.
Comment 1 Filip Pizlo 2015-05-21 18:49:38 PDT 
Created attachment 253572 [details]
the patch
Comment 2 WebKit Commit Bot 2015-05-21 18:52:09 PDT 
Attachment 253572 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1055:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2015-05-21 23:33:03 PDT 
Landed in http://trac.webkit.org/changeset/184755