Bug 145289 - [iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
Summary: [iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-21 18:15 PDT by Jer Noble
Modified: 2015-05-29 11:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.90 KB, patch)
2015-05-21 18:28 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2015-05-21 18:15:12 PDT
[iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
Comment 1 Jer Noble 2015-05-21 18:28:35 PDT
Created attachment 253570 [details]
Patch
Comment 2 Jer Noble 2015-05-21 23:57:43 PDT
Committed r184760: <http://trac.webkit.org/changeset/184760>
Comment 3 Daniel Bates 2015-05-27 14:43:31 PDT
(In reply to comment #2)
> Committed r184760: <http://trac.webkit.org/changeset/184760>

This broke the internal iOS bots because the file AVPlayerViewController_WebKitOnly.h, included in file Source/WebCore/platform/spi/mac/AVFoundationSPI.h, may not exist.
Comment 4 Daniel Bates 2015-05-27 14:43:49 PDT
As far as I can tell from the looking at the patch we don't seem to make use of
Comment 5 Daniel Bates 2015-05-27 14:44:29 PDT
(In reply to comment #4)
> As far as I can tell from the looking at the patch we don't seem to make use
> of

I meant to write:

As far as I can tell from the looking at the patch we don't seem to make use of AVPlayerViewController_WebKitOnly.h. We should remove it.
Comment 6 Daniel Bates 2015-05-27 14:55:30 PDT
(In reply to comment #5)
> As far as I can tell from the looking at the patch we don't seem to make use
> of AVPlayerViewController_WebKitOnly.h. We should remove it.

Filed bug #145414 to remove the inclusion of header AVPlayerViewController_WebKitOnly.h from AVFoundationSPI.h.
Comment 7 Jer Noble 2015-05-27 15:13:05 PDT
rdar://problem/21064692
Comment 8 Radar WebKit Bug Importer 2015-05-27 15:13:42 PDT
<rdar://problem/21130440>
Comment 9 Jer Noble 2015-05-27 15:13:52 PDT
Follow up build-fix landed by Daniel Bates in https://trac.webkit.org/r184924.