Add an "initiated by user gesture" flag to ResourceRequest This is in support of https://bugs.webkit.org/show_bug.cgi?id=145280, and will be tested along with that bug.
Created attachment 253540 [details] Patch v1
Created attachment 253544 [details] Patch v2 - Less WK1 test crashing
Created attachment 253546 [details] Patch v3 - More iOS building
Comment on attachment 253546 [details] Patch v3 - More iOS building View in context: https://bugs.webkit.org/attachment.cgi?id=253546&action=review > Source/WebCore/platform/mac/WebCoreSystemInterface.h:321 > +#if PLATFORM(COCOA) PLATFORM(COCOA) shouldn't be needed in platform/mac > Source/WebCore/platform/mac/WebCoreSystemInterface.mm:173 > +#if PLATFORM(COCOA) shouldn't be needed. > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:211 > +#if PLATFORM(COCOA) shouldn't be needed.
Created attachment 253552 [details] Patch for landing.
Comment on attachment 253552 [details] Patch for landing. Clearing flags on attachment: 253552 Committed r184741: <http://trac.webkit.org/changeset/184741>
Comment on attachment 253546 [details] Patch v3 - More iOS building View in context: https://bugs.webkit.org/attachment.cgi?id=253546&action=review > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:31 > WebSystemInterface exists solely for binding symbols from libWebKitSystemInterface. It’s unnecessary and inappropriate to use it for this.
(In reply to comment #7) > Comment on attachment 253546 [details] > Patch v3 - More iOS building > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253546&action=review > > > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:31 > > > > WebSystemInterface exists solely for binding symbols from > libWebKitSystemInterface. It’s unnecessary and inappropriate to use it for > this. I was not aware that it was inappropriate, as I haven't seen that documented anywhere. I would like to here the obviously better alternative that makes it unnecessary, as I was unable to figure another obvious way for WebCore to have access to a static string provided by WebKit. There might *be* an obvious way, I just don't know what it is off hand.
(In reply to comment #8) > (In reply to comment #7) > > Comment on attachment 253546 [details] > > Patch v3 - More iOS building > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=253546&action=review > > > > > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:31 > > > > > > > WebSystemInterface exists solely for binding symbols from > > libWebKitSystemInterface. It’s unnecessary and inappropriate to use it for > > this. > > I was not aware that it was inappropriate, as I haven't seen that documented > anywhere. > > I would like to here the obviously better alternative that makes it > unnecessary, as I was unable to figure another obvious way for WebCore to > have access to a static string provided by WebKit. > > There might *be* an obvious way, I just don't know what it is off hand. I realize now that I shifted strategies partway through my patch in a way that no longer required the string to be WebKit provided, and in fact it can live in WebCore. Will fix.
Created attachment 253594 [details] Followup to fix WCSI/WSI misusage - v1
http://trac.webkit.org/changeset/184775
Trying to fix the build in r184783.