Bug 14527 – Presence of WebCore/ForwardingHeaders/JavaScriptCore breaks standalone WebCore build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Rowe (bdash)]

WebCore needs to be able to build without having JavaScriptCore.framework in the built products.  In several places WebCore uses framework-style #includes to pull in JavaScriptCore headers, such as InspectorController.h:33 which does
#include <JavaScriptCore/JSContextRef.h>

JSContextRef.h lives in the source under JavaScriptCore/API/JSContextRef.h.  As ForwardingHeaders is added to the header search path, any headers inside ForwardingHeaders/JavaScriptCore will be found before those inside the system JavaScriptCore.framework if there is no JavaScriptCore.framework in the built products directory.  ForwardingHeaders/JavaScriptCore exists at this point because the Qt and Gdk ports do not have a "copy headers" build step which copies headers into the structure that WebCore expects.

The end result: until this is resolved we need to manually remove WebCore/ForwardingHeaders/JavaScriptCore before building WebCore standalone or else the build will fail.

[Mark Rowe (bdash)]

<rdar://problem/5313350>

[Mark Rowe (bdash)]

The Qt and Gdk port build systems need to be changed to copy the headers into expected locations ASAP.  We can't have this breaking the Mac build for long.

[George Staikos]

I'm really not sure what we should do here.  Copying the files is ugly and it seems like this is both an issue of using install-time headers during compile time, and of trying to hack around an OS X limitation by adding that limitation and workaround everywhere else too.

[Mark Rowe (bdash)]

I'm not overly concerned with how this is resolved.  If you have a solution that will work without the copying of headers, please feel free to take that approach.

[Holger Freyther]

Created attachment 15475 [details]
Move WebCore/ForwardingHeaders/JavaScriptCore away from WebCore

The most easy way is to copy the offending directory to a place not used by the MacPort. One proposal for such a directory would be JavaScriptCore/ForwardingHeaders.

[Darin Adler]

Comment on attachment 15475 [details]
Move WebCore/ForwardingHeaders/JavaScriptCore away from WebCore

r=me

[David Kilzer (:ddkilzer)]

Fixed by darin in r24210.

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> Fixed by darin in r24210.

Build fix by staikos in r24224.