Bug 14527 - Presence of WebCore/ForwardingHeaders/JavaScriptCore breaks standalone WebCore build
Summary: Presence of WebCore/ForwardingHeaders/JavaScriptCore breaks standalone WebCor...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2007-07-04 22:52 PDT by Mark Rowe (bdash)
Modified: 2007-07-11 21:23 PDT (History)
4 users (show)

See Also:

Move WebCore/ForwardingHeaders/JavaScriptCore away from WebCore (5.69 KB, patch)
2007-07-11 11:01 PDT, Holger Freyther
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2007-07-04 22:52:34 PDT
WebCore needs to be able to build without having JavaScriptCore.framework in the built products.  In several places WebCore uses framework-style #includes to pull in JavaScriptCore headers, such as InspectorController.h:33 which does
#include <JavaScriptCore/JSContextRef.h>

JSContextRef.h lives in the source under JavaScriptCore/API/JSContextRef.h.  As ForwardingHeaders is added to the header search path, any headers inside ForwardingHeaders/JavaScriptCore will be found before those inside the system JavaScriptCore.framework if there is no JavaScriptCore.framework in the built products directory.  ForwardingHeaders/JavaScriptCore exists at this point because the Qt and Gdk ports do not have a "copy headers" build step which copies headers into the structure that WebCore expects.

The end result: until this is resolved we need to manually remove WebCore/ForwardingHeaders/JavaScriptCore before building WebCore standalone or else the build will fail.
Comment 1 Mark Rowe (bdash) 2007-07-04 22:52:50 PDT
Comment 2 Mark Rowe (bdash) 2007-07-04 22:55:14 PDT
The Qt and Gdk port build systems need to be changed to copy the headers into expected locations ASAP.  We can't have this breaking the Mac build for long.
Comment 3 George Staikos 2007-07-06 10:49:43 PDT
I'm really not sure what we should do here.  Copying the files is ugly and it seems like this is both an issue of using install-time headers during compile time, and of trying to hack around an OS X limitation by adding that limitation and workaround everywhere else too.
Comment 4 Mark Rowe (bdash) 2007-07-09 20:31:43 PDT
I'm not overly concerned with how this is resolved.  If you have a solution that will work without the copying of headers, please feel free to take that approach.
Comment 5 Holger Freyther 2007-07-11 11:01:00 PDT
Created attachment 15475 [details]
Move WebCore/ForwardingHeaders/JavaScriptCore away from WebCore

The most easy way is to copy the offending directory to a place not used by the MacPort. One proposal for such a directory would be JavaScriptCore/ForwardingHeaders.
Comment 6 Darin Adler 2007-07-11 12:21:35 PDT
Comment on attachment 15475 [details]
Move WebCore/ForwardingHeaders/JavaScriptCore away from WebCore

Comment 7 David Kilzer (:ddkilzer) 2007-07-11 21:20:47 PDT
Fixed by darin in r24210.

Comment 8 David Kilzer (:ddkilzer) 2007-07-11 21:23:19 PDT
(In reply to comment #7)
> Fixed by darin in r24210.

Build fix by staikos in r24224.