Bug 145264 - [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
Summary: [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency tree / graph
 
Reported: 2015-05-21 06:27 PDT by Csaba Osztrogonác
Modified: 2015-06-01 03:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2015-05-21 06:49 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2015-05-21 07:10 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-05-21 06:27:11 PDT 
issuse no1:
------------
Now unused parameter warnings are suppressed in WebKit2, but unfortunately
the actual mechanism is only works with GCC, but not with Clang.

The problem is that the command like looks like "-Wno-unused-parameter -Wall -Wextra"
and Clang's -Wextra switches the unused parameter warning back. The proper fix is
to put -Wno-unused-parameter after -Wextra.

issuse no2:
------------
There are zillion unused parameter warnings in TestNetscapePlugIn, but we can't see
them because of a bug: WEBKIT_SET_EXTRA_COMPILER_FLAGS(TestNetscapePlugin) is missing
and no warnings options are passed to TestNetscapePlugIn. We should fix it and
suppress only the unused parameter warnings there.
Comment 1 Csaba Osztrogonác 2015-05-21 06:49:25 PDT 
Created attachment 253522 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-05-21 07:10:33 PDT 
Created attachment 253523 [details]
Patch

typo fixed in changelog
Comment 3 Csaba Osztrogonác 2015-06-01 03:57:53 PDT 
Comment on attachment 253523 [details]
Patch

Clearing flags on attachment: 253523

Committed r185056: <http://trac.webkit.org/changeset/185056>
Comment 4 Csaba Osztrogonác 2015-06-01 03:58:00 PDT 
All reviewed patches have been landed.  Closing bug.