Bug 145259 - MSVC internal compiler error when compiling TemplateRegistryKey class.
Summary: MSVC internal compiler error when compiling TemplateRegistryKey class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-21 04:23 PDT by peavo
Modified: 2015-05-22 10:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.20 KB, patch)
2015-05-21 04:33 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-05-21 04:23:52 PDT
I get an internal compiler error when compiling TemplateRegistryKey.h with MSVC (Visual Studio Express).
Comment 1 peavo 2015-05-21 04:33:43 PDT
Created attachment 253520 [details]
Patch
Comment 2 Alex Christensen 2015-05-21 09:38:20 PDT
Comment on attachment 253520 [details]
Patch

Strange.  This should call Vector(std::initializer_list<String>), but I don't think it's a big deal to remove the explicit initialization to an empty Vector when that is the default behavior anyway.
Comment 3 peavo 2015-05-21 09:49:05 PDT
(In reply to comment #2)
> Comment on attachment 253520 [details]
> Patch
> 
> Strange.  This should call Vector(std::initializer_list<String>), but I
> don't think it's a big deal to remove the explicit initialization to an
> empty Vector when that is the default behavior anyway.

Yes, I'm also a bit surprised that the WinCairo bot doesn't seem to have a problem, maybe we have slightly different versions of MSVC.

Thanks for reviewing :)
Comment 4 WebKit Commit Bot 2015-05-21 10:27:57 PDT
Comment on attachment 253520 [details]
Patch

Clearing flags on attachment: 253520

Committed r184717: <http://trac.webkit.org/changeset/184717>
Comment 5 WebKit Commit Bot 2015-05-21 10:28:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2015-05-22 09:03:21 PDT
You should make sure you are running "Update 4" of Visual Studio. It fixes a number of compiler bugs. It does not show up automatically when you do a "check for updates", you have to go to the MSDN site and locate the download link. :-(
Comment 7 peavo 2015-05-22 10:58:09 PDT
(In reply to comment #6)
> You should make sure you are running "Update 4" of Visual Studio. It fixes a
> number of compiler bugs. It does not show up automatically when you do a
> "check for updates", you have to go to the MSDN site and locate the download
> link. :-(

Ah, ok, thanks :)